FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: remove unnecessary copy operations in tracing code by addaleax · Pull Request #20356 · nodejs/node · GitHub

/ node Public

src: remove unnecessary copy operations in tracing code - #20356

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:trace-events-copies
ConversationCommits (1)ChecksFiles changed
Closed

src: remove unnecessary copy operations in tracing code#20356
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:trace-events-copies

Conversation

addaleax commented Apr 27, 2018

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

addaleax added c++ Issues and PRs that require attention from people who are familiar with C++. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 27, 2018
nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 27, 2018

addaleax commented Apr 27, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/18073/

Not urgent but I think fast-tracking makes sense, feel free to 👍 this comment if you do too :)

jasnell reviewed Apr 27, 2018
View reviewed changes
Comment thread src/node_trace_events.cc
ASSIGN_OR_RETURN_UNWRAP(&category_set, args.Holder());
CHECK_NE(category_set, nullptr);
auto categories = category_set->GetCategories();
const auto& categories = category_set->GetCategories();

jasnell Apr 27, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

thank you, I consistently forget that the const and & are still required with auto.

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 27, 2018

apapirovski commented Apr 28, 2018

Copy link
Copy Markdown
Contributor

Landed in 7016ee6

apapirovski pushed a commit that referenced this pull request Apr 28, 2018
src: remove unnecessary copy operations in tracing
7016ee6 
PR-URL: #20356
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request May 4, 2018
src: remove unnecessary copy operations in tracing
31812ed 
PR-URL: #20356
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins mentioned this pull request May 8, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
+1 more reviewer
apapirovski apapirovski approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL