VS 2015 support - #2036
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Cherry-picking leftover... %nosnapshot_arg% should be %snapshot_arg%
Sorry, something went wrong.
|
Thanks @orangemocha, decided that they belong in a separate commit rather than amending the cherry-pick |
Sorry, something went wrong.
|
LGTM |
Sorry, something went wrong.
|
ran another CI against this and got this on win2008 only: not ok 661 - test-timers-first-fire.js
#
#assert.js:89
# throw new assert.AssertionError({
# ^
#AssertionError: Timer fired early
# at null._onTimeout (c:\workspace\iojs+pr+win\nodes\win2008r2\test\parallel\test-timers-first-fire.js:12:10)
# at Timer.listOnTimeout (timers.js:89:15)
#timer fired in -0.6709120000000013
@Fishrock123 you're deep in timers now, does this fit into any existing context we have? I'm not sure if this has shown up before or not. Merging regardless because this is unrelated. |
Sorry, something went wrong.
vcbuild.bat calls python configure before setting GYP_MSVS_VERSION, so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py) defaults to 'auto' and selects VS 2005. vcbuild sets the environment in the current shell, so this issue would manifest itself only on the first invocation of the script in any given shell windows. Reviewed-By: Julien Gilli <jgilli@fastmail.fm> PR-URL: nodejs/node-v0.x-archive#20109
PR-URL: nodejs#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
PR-URL: nodejs#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
|
@rvagg Yes, that happens sometimes. It's a minor bug somewhere very deep in windows libuv that will cause timers to occasionally fire quite early. Or something along those lines anyways. I think @orangemocha knew a bit more. |
Sorry, something went wrong.
|
Hi sorry, I just got around to installing VS2015 on my desktop yesterday. Nice work! |
Sorry, something went wrong.
PR-URL: nodejs#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
PR-URL: nodejs#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
Yes, that issue has been around for a while and that test is marked as flaky in joyent\node. nodejs/node-v0.x-archive#8960 We have been working on a fix (libuv/libuv#385), but it's still work in progress. |
Sorry, something went wrong.
PR-URL: #2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
PR-URL: #2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
PR-URL: #2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
PR-URL: #2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
PR-URL: nodejs#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
PR-URL: nodejs#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
This is a port of nodejs/node@4208dc4 . Original commit message: PR-URL: nodejs/node#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> PR-URL: #25857 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
This is a port of 4208dc4 . Original commit message: PR-URL: nodejs#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> This was ported to v0.10 in nodejs/node-v0.x-archive#25857
This is a port of 4208dc4 . Original commit message: PR-URL: #2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> This was ported to v0.10 in nodejs/node-v0.x-archive#25857 PR-URL: #2843 Reviewed-By: rvagg - Rod Vagg <rod@vagg.org> Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
This is a port of 4208dc4 . Original commit message: PR-URL: nodejs/node#2036 Reviewed-By: Alexis Campailla <alexis@janeasystems.com> This was ported to v0.10 in nodejs#25857 PR-URL: nodejs/node#2843 Reviewed-By: rvagg - Rod Vagg <rod@vagg.org> Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Continues on from #478 but against master this time
/R=@nodejs/platform-windows