doc: remove redundant table of contents for N-API - #20395
Closed
AyushG3112 wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Since the table of contents is built dynamically when building the documentation, the additional table of contents is redundant and an extra overhead to maintain.
Trott
approved these changes
Apr 29, 2018
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
💯
Sorry, something went wrong.
trivikr
approved these changes
Apr 29, 2018
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
If you're a Collaborator and think this should be fast-tracked, leave a 👍 on this comment. |
Sorry, something went wrong.
vsemozhetbyt
approved these changes
Apr 29, 2018
TimothyGu
approved these changes
Apr 29, 2018
devsnek
approved these changes
Apr 29, 2018
Copy link
Copy Markdown
Contributor
Author
|
Should this be backported to 10.x? The Table of Contents is still present here and is imcomplete. EDIT: Sorry closed by misclick. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
If the commit here can't be cleanly cherry-picked to the 10.x.-staging branch, then doing a backport would probably be useful. But it might cherry-pick cleanly, in which case: No additional work required. |
Sorry, something went wrong.
cjihrig
approved these changes
Apr 30, 2018
Copy link
Copy Markdown
Contributor
Author
|
Can this land yet? |
Sorry, something went wrong.
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
May 1, 2018
Since the table of contents is built dynamically when building the documentation, the additional table of contents is redundant and an extra overhead to maintain. PR-URL: nodejs#20395 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
4 tasks
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
Since the table of contents is built dynamically when building the documentation, the additional table of contents is redundant and an extra overhead to maintain. PR-URL: #20395 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the table of contents is built dynamically when building the documentation, the additional table of contents is redundant and an extra overhead to maintain.
Checklist