FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: specify types of listener parameter by vsemozhetbyt · Pull Request #20405 · nodejs/node · GitHub

/ node Public

doc: specify types of listener parameter - #20405

Closed
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:doc-process-specify-listener-param-type
Closed

doc: specify types of listener parameter#20405
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:doc-process-specify-listener-param-type

Conversation

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

We cannot manage with {any} because message cannot be of Symbol or undefined types.

We cannot manage with `{any}` because `message` cannot be
of `Symbol` or `undefined` types.
vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 29, 2018
nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Apr 29, 2018

Copy link
Copy Markdown
Contributor Author

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

Copy link
Copy Markdown
Contributor Author

vsemozhetbyt added a commit that referenced this pull request May 2, 2018
We cannot manage with `{any}` because `message` cannot be
of `Symbol` or `undefined` types.

PR-URL: #20405
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Copy link
Copy Markdown
Contributor Author

Landed in aaca38a
Thanks for the reviews.

vsemozhetbyt deleted the doc-process-specify-listener-param-type branch May 2, 2018 02:59
MylesBorins pushed a commit that referenced this pull request May 4, 2018
We cannot manage with `{any}` because `message` cannot be
of `Symbol` or `undefined` types.

PR-URL: #20405
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request May 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. process Issues and PRs related to the process subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL