http2: reduce require calls in http2/core - #20422
Closed
danbev wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This commit removes unnecesary requires of http and internal/util in http2/core.js
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
-0 as this is mainly churn out of my perspective. |
Sorry, something went wrong.
apapirovski
approved these changes
Apr 30, 2018
TimothyGu
approved these changes
Apr 30, 2018
lpinca
approved these changes
Apr 30, 2018
trivikr
approved these changes
May 1, 2018
danbev
added a commit
to danbev/node
that referenced
this pull request
May 2, 2018
This commit removes unnecesary requires of http and internal/util in http2/core.js PR-URL: nodejs#20422 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
This commit removes unnecesary requires of http and internal/util in http2/core.js PR-URL: #20422 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Aug 23, 2018
This commit removes unnecesary requires of http and internal/util in http2/core.js PR-URL: nodejs#20422 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Sep 11, 2018
This commit removes unnecesary requires of http and internal/util in http2/core.js PR-URL: nodejs#20422 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Sep 19, 2018
This commit removes unnecesary requires of http and internal/util in http2/core.js PR-URL: nodejs#20422 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Oct 16, 2018
This commit removes unnecesary requires of http and internal/util in http2/core.js PR-URL: nodejs#20422 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Oct 17, 2018
This commit removes unnecesary requires of http and internal/util in http2/core.js Backport-PR-URL: #22850 PR-URL: #20422 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes unnecesary requires of http and internal/util in
http2/core.js
Checklist