FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: doc cleanup by mhdawson · Pull Request #20430 · nodejs/node · GitHub

/ node Public

doc: doc cleanup - #20430

Closed
mhdawson wants to merge 1 commit into
nodejs:masterfrom
mhdawson:napi-doc100
ConversationCommits (1)ChecksFiles changed
Closed

doc: doc cleanup#20430
mhdawson wants to merge 1 commit into
nodejs:masterfrom
mhdawson:napi-doc100

Conversation

mhdawson commented Apr 30, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Partial doc cleanup as per
#20421

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added doc Issues and PRs related to the documentations. dont-land-on-v4.x node-api Issues and PRs related to the Node-API. labels Apr 30, 2018
mhdawson mentioned this pull request Apr 30, 2018
Closed

vsemozhetbyt commented Apr 30, 2018

Copy link
Copy Markdown
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 30, 2018

vsemozhetbyt commented Apr 30, 2018

Copy link
Copy Markdown
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/637/

vsemozhetbyt commented Apr 30, 2018

Copy link
Copy Markdown
Contributor

(nit: on landing, the commit message title needs to be changed into doc: cleanup doc or maybe doc: cleanup n-api.md.)

vsemozhetbyt mentioned this pull request Apr 30, 2018
Closed
3 tasks

mhdawson commented Apr 30, 2018

Copy link
Copy Markdown
Member Author

@gabrielf can you review this one.

gabrielschulhof approved these changes May 2, 2018
View reviewed changes

gabrielschulhof left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

gabrielschulhof commented May 2, 2018

Copy link
Copy Markdown
Contributor

nit: s/Partical/Partial/ in the commit message.

trivikr added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 3, 2018
doc: cleanup n-api.md doc
ab58ab1 
Partial doc cleanup as per
nodejs#20421

mhdawson commented May 3, 2018

Copy link
Copy Markdown
Member Author

Fixed up commit comment, previous CI run looked good, will land.

mhdawson commented May 3, 2018

Copy link
Copy Markdown
Member Author

Landed as 4740e5d

mhdawson closed this May 3, 2018
mhdawson added a commit that referenced this pull request May 3, 2018
doc: cleanup n-api.md doc
4740e5d 
Partial doc cleanup as per
#20421

PR-URL: #20430
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 4, 2018
doc: cleanup n-api.md doc
36d93da 
Partial doc cleanup as per
#20421

PR-URL: #20430
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request May 8, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 8, 2018
doc: cleanup n-api.md doc
b2d6eb7 
Partial doc cleanup as per
#20421

PR-URL: #20430
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
mhdawson mentioned this pull request Jul 4, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Jul 9, 2018
doc: cleanup n-api.md doc
6eec3fc 
Partial doc cleanup as per
#20421

PR-URL: #20430
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 10, 2018
doc: cleanup n-api.md doc
f4b9985 
Partial doc cleanup as per
#20421

PR-URL: #20430
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
doc: cleanup n-api.md doc
4709734 
Partial doc cleanup as per
#20421

PR-URL: #20430
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
mhdawson deleted the napi-doc100 branch September 30, 2019 13:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
gabrielschulhof gabrielschulhof approved these changes
cjihrig cjihrig approved these changes
trivikr trivikr approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL