FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix a typo by yanxyz · Pull Request #2050 · nodejs/node · GitHub

/ node Public

doc: fix a typo - #2050

Closed
yanxyz wants to merge 1 commit into
nodejs:masterfrom
yanxyz:patch-1
Closed

doc: fix a typo#2050
yanxyz wants to merge 1 commit into
nodejs:masterfrom
yanxyz:patch-1

Conversation

yanxyz commented Jun 24, 2015

Copy link
Copy Markdown
Contributor

No description provided.

Trott commented Jun 24, 2015

Copy link
Copy Markdown
Member

M is the abbreviation for a thousand. MM is a million. Perhaps the thing to do is just get rid of the abbreviation altogether and spell out the number.

Copy link
Copy Markdown
Contributor

I agree with @Trott. MM is an abbreviation more used in finance, and is a little confusing here. We can spare the extra characters.

mscdex added the doc Issues and PRs related to the documentations. label Jun 24, 2015

rvagg commented Jun 24, 2015

Copy link
Copy Markdown
Member

MM isn't very tech-centric where we are used to k for thousand and M for million; tbh I hate the finance-centric MM.

Happy to defer to @Trott on this one though, just registering my opinion.

yanxyz commented Jun 25, 2015

Copy link
Copy Markdown
Contributor Author

Oh, sorry, I don't know there is a such abbreviation in finance. However 'M' is commonly used in the technology area.

Trott commented Jun 25, 2015

Copy link
Copy Markdown
Member

I agree that MM is a bit odd in this context. And M does seem to be used to mean "million" at least as often as it is used to mean "thousand".

Given all this, I would not object to leaving it as MM and I would not object to changing it to M.

I do think the best thing to do is just spell it out and dispense with the abbreviations altogether. That would provide the most clarity with no real downside. But this is just me bike-shedding.

cjihrig commented Jun 25, 2015

Copy link
Copy Markdown
Contributor

+1 to just spelling out the full word.

yanxyz commented Jun 25, 2015

Copy link
Copy Markdown
Contributor Author

ok.

yanxyz closed this Jun 25, 2015
cjihrig pushed a commit that referenced this pull request Jun 25, 2015
Refs: #2050
PR-URL: #2053
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
mscdex pushed a commit to mscdex/io.js that referenced this pull request Jul 9, 2015
Refs: nodejs#2050
PR-URL: nodejs#2053
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL