FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

console: console.table() uses colored inspect by makenowjust · Pull Request #20510 · nodejs/node · GitHub

/ node Public

console: console.table() uses colored inspect - #20510

Closed
makenowjust wants to merge 1 commit into
nodejs:masterfrom
makenowjust:console-table-color
ConversationCommits (1)ChecksFiles changed
Closed

console: console.table() uses colored inspect#20510
makenowjust wants to merge 1 commit into
nodejs:masterfrom
makenowjust:console-table-color

Conversation

makenowjust commented May 4, 2018

Copy link
Copy Markdown
Contributor

This makes console.table() inspect objects with color if available like console.log.

Currently console.table with true, false, null or undefined shows colored values because it calls console.log internally.

However console.table with objects does not show colored value at all.

It seems a bug and I wish console.table shows colored values.

I'm first time contributor. I have a questions: Is this PR change just a bug fixing? -- Or breaking change?
Probably it is the important concern of nodejs/node, which is used for versioning. I can't determine that. What do you think?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

console: console.table() uses colored inspect
f383ab0 
This makes console.table() inspect objects with color if available like
`console.log`.
nodejs-github-bot added the console Issues and PRs related to the console subsystem. label May 4, 2018

vsemozhetbyt commented May 4, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/14659/

vsemozhetbyt commented May 4, 2018

Copy link
Copy Markdown
Contributor

cc @devsnek @TimothyGu @BridgeAR as per #18137

jasnell added the semver-minor PRs that contain new features and should be released in the next minor version. label May 4, 2018
devsnek approved these changes May 4, 2018
View reviewed changes

devsnek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

looks ok, although I would think this is patch not minor

vsemozhetbyt added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 4, 2018
BridgeAR approved these changes May 5, 2018
View reviewed changes

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

BridgeAR commented May 5, 2018

Copy link
Copy Markdown
Member

General note: we should likely consider adding more default options here as the defaults might have been manipulated by the user or modules. But that is out of the scope of this PR.

vsemozhetbyt commented May 8, 2018

Copy link
Copy Markdown
Contributor

Landed in 6af26b1
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request May 8, 2018
console: make console.table() use colored inspect
6af26b1 
This makes `console.table()` inspect objects with color if available
like `console.log()`.

PR-URL: #20510
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 8, 2018
console: make console.table() use colored inspect
fa0565e 
This makes `console.table()` inspect objects with color if available
like `console.log()`.

PR-URL: #20510
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request May 8, 2018
2018-05-08, Version 10.1.0 (Current)
216acb1 
Notable Changes:

* console:
  - make console.table() use colored inspect (TSUYUSATO Kitsune)
    #20510
* fs:
  - move fs/promises to fs.promises (cjihrig)
    #20504
* http:
  - added aborted property to request (Robert Nagy)
    #20094
* n-api:
  - initialize a module via a special symbol (Gabriel Schulhof)
    #20161
* src:
  - add public API to expose the main V8 Platform (Allen Yonghuang Wang)
    #20447

PR-URL: Coming Soon
MylesBorins mentioned this pull request May 8, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 8, 2018
console: make console.table() use colored inspect
3b5c6f1 
This makes `console.table()` inspect objects with color if available
like `console.log()`.

PR-URL: #20510
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request May 8, 2018
2018-05-08, Version 10.1.0 (Current)
f8ed2a6 
Notable Changes:

* console:
  - make console.table() use colored inspect (TSUYUSATO Kitsune)
    #20510
* fs:
  - move fs/promises to fs.promises (cjihrig)
    #20504
* http:
  - added aborted property to request (Robert Nagy)
    #20094
* n-api:
  - initialize a module via a special symbol (Gabriel Schulhof)
    #20161
* src:
  - add public API to expose the main V8 Platform (Allen Yonghuang Wang)
    #20447

PR-URL: #20606
MylesBorins pushed a commit that referenced this pull request May 9, 2018
console: make console.table() use colored inspect
a7758c7 
This makes `console.table()` inspect objects with color if available
like `console.log()`.

PR-URL: #20510
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request May 9, 2018
2018-05-08, Version 10.1.0 (Current)
687867d 
Notable Changes:

* console:
  - make console.table() use colored inspect (TSUYUSATO Kitsune)
    #20510
* fs:
  - move fs/promises to fs.promises (cjihrig)
    #20504
* http:
  - added aborted property to request (Robert Nagy)
    #20094
* n-api:
  - initialize a module via a special symbol (Gabriel Schulhof)
    #20161
* src:
  - add public API to expose the main V8 Platform (Allen Yonghuang Wang)
    #20447

PR-URL: #20606
MylesBorins added a commit that referenced this pull request May 9, 2018
2018-05-08, Version 10.1.0 (Current)
2c0fc3b 
Notable Changes:

* console:
  - make console.table() use colored inspect (TSUYUSATO Kitsune)
    #20510
* fs:
  - move fs/promises to fs.promises (cjihrig)
    #20504
* http:
  - added aborted property to request (Robert Nagy)
    #20094
* n-api:
  - initialize a module via a special symbol (Gabriel Schulhof)
    #20161
* src:
  - add public API to expose the main V8 Platform (Allen Yonghuang Wang)
    #20447

PR-URL: #20606
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
BridgeAR BridgeAR approved these changes
trivikr trivikr approved these changes
+3 more reviewers
JacksonTian JacksonTian approved these changes
TimothyGu TimothyGu approved these changes
devsnek devsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. console Issues and PRs related to the console subsystem. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL