module: force require('process') to return a reference to process by lxe · Pull Request #206 · nodejs/node · GitHub

This makes require('process') always return a reference to the global process object. Fixes #157

Why not module.exports = global.process?

@vkurchatkin there were a few ways to do this... making lib/process.js with module.exports = process is certainly one of them, and I wasn't sure which one would look more like a hack. We're already removing lib/sys which did the one-line re-export, so I was thinking we probably shouldn't create whole files just to do a re-export.

I prefer the lib/process.js approach. Anything that doesn't require hacking lib/module.js.

@bnoordhuis added lib/process.js instead of the conditionals.

Can you change this to either // Copyright io.js contributors or your own / your company's name?

LGTM technically but as the discussion in #157 doesn't appear to have reached a conclusion, I won't merge it straight away. I'll bring it up at the next TC meeting unless enough TC members +1 it before that.

Happy holidays everyone!

@lxe Still one nit but if you fix that, I'll land it. Thanks.

This makes require('process') always return a reference to the global process object.

@bnoordhuis totally missed that one! Thanks.

This makes require('process') always return a reference to the global process object. PR-URL: #206 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Cheers Aleksey, landed in d8586ea. I had to reword the first line to make it fit in 50 columns. Thanks!

Great stuff @bnoordhuis. thank you!

ftr, agreed to merge this in TC meeting 2014-12-30 #229

lxe force-pushed the require-process branch from d282450 to 1e6df6a Compare December 23, 2014 23:09

bnoordhuis reviewed Dec 24, 2014
View reviewed changes

bnoordhuis added the tc-agenda label Dec 24, 2014

lxe force-pushed the require-process branch from 64087ac to fef4b88 Compare December 25, 2014 21:48

rvagg mentioned this pull request Dec 26, 2014

io.js TC Meeting 2014-12-30 #211

Closed

bnoordhuis removed the tc-agenda label Dec 30, 2014

piscisaureus closed this Dec 30, 2014

piscisaureus reopened this Dec 30, 2014

module: force require('process') to return a reference to process

cec8255

This makes require('process') always return a reference to the global process object.

lxe force-pushed the require-process branch from fef4b88 to cec8255 Compare December 30, 2014 22:26

bnoordhuis pushed a commit that referenced this pull request Dec 30, 2014

lib: introduce process module

d8586ea

This makes require('process') always return a reference to the global process object. PR-URL: #206 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

bnoordhuis closed this Dec 30, 2014

cjihrig mentioned this pull request Jan 2, 2015

Make process requireable #157

Closed

rvagg mentioned this pull request Jan 3, 2015

governance: Add new Collaborators #234

Closed

andrewdeandrade mentioned this pull request Jan 20, 2015

Make process requireable nodejs/node-v0.x-archive#8866

Closed

snyk-bot mentioned this pull request Jan 8, 2020

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 timscharfenort/node#5

Open

snyk-bot mentioned this pull request Jul 5, 2020

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 sitedata/node#3

Open

snyk-bot mentioned this pull request Aug 11, 2020

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 radiumrasheed/node#3

Open

snyk-bot mentioned this pull request Mar 9, 2022

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 RickAllMighty8195/node#10

Open

snyk-bot mentioned this pull request Mar 25, 2022

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 lamjay2704/node#9

Open

snyk-bot mentioned this pull request Jul 19, 2022

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 jgowdy/node#5

Open

snyk-bot mentioned this pull request Oct 10, 2022

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 lokera666/node#4

Open

This was referenced Feb 14, 2023

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 Dixiejane/node#5

Open

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 SanchitMahajan236/node#8

Closed

snyk-bot mentioned this pull request Mar 15, 2023

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 davidmather/node#1

Open

snyk-bot mentioned this pull request Mar 22, 2023

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 Bank4500/nodejs#5

Open

snyk-bot mentioned this pull request May 5, 2023

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 ashly1111111/node#14

Open

nicholaschoi168 mentioned this pull request May 16, 2023

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 nicholaschoi168/node#7

Open

pranathi-nallamilli mentioned this pull request Aug 5, 2023

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 pranathi-nallamilli/node#5

Open

JCsomeShots mentioned this pull request Sep 19, 2023

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 JCsomeShots/node#1

Open

kingjay66 mentioned this pull request Oct 15, 2023

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 kingjay66/node#4

Open

Jingyi090 mentioned this pull request Nov 17, 2023

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 Jingyi090/node#1

Open

nickfnblum mentioned this pull request Nov 21, 2023

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 nickfnblum/node#7

Open

ashly1111111 mentioned this pull request Nov 24, 2023

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 ashly1111111/node#69

Open

aravindb26 mentioned this pull request Jan 4, 2024

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 aravindb26/node#1

Open

CxsLucyfer mentioned this pull request Jan 29, 2024

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 CxsLucyfer/node#1

Open

gr00nd mentioned this pull request Feb 6, 2024

[Snyk] Upgrade globals from 10.1.0 to 13.24.0 gr00nd/node#10

Open

ahamedislam mentioned this pull request Feb 22, 2024

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 ahamedislam/node#1

Open

DanyRay420 mentioned this pull request Feb 24, 2024

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 DanyRay420/node#2

Open

matrix-compute mentioned this pull request Mar 28, 2024

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 matrix-compute/node.js#2

Open

ashly1111111 mentioned this pull request Mar 29, 2024

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 ashly1111111/node#94

Open

lairortega mentioned this pull request Apr 14, 2024

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 lairortega/node#1

Open

yaseenaljamal mentioned this pull request Apr 25, 2024

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 yaseenaljamal/node#5

Open

dannybrown13 mentioned this pull request May 7, 2024

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 dannybrown13/node#93

Open

CharliesAngel1 mentioned this pull request May 7, 2024

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 CharliesAngel1/node#14

Open

snyk-io Bot mentioned this pull request May 21, 2024

[Snyk] Upgrade rollup-plugin-node-resolve from 4.0.0 to 4.2.4 Hawthorne001/node2#2

Open

syg pushed a commit to syg/node that referenced this pull request May 5, 2025

Update parallel.status (nodejs#206 )

d50c960

bakkot pushed a commit to bakkot/node that referenced this pull request May 11, 2026

Update parallel.status (nodejs#206 )

ca7033e

module: force require('process') to return a reference to process by lxe · Pull Request #206 · nodejs/node · GitHub

Repository navigation

module: force require('process') to return a reference to process - #206

module: force require('process') to return a reference to process#206
lxe wants to merge 1 commit into
nodejs:v0.12from
lxe:require-process

lxe commented Dec 23, 2014

Uh oh!

vkurchatkin commented Dec 23, 2014

Uh oh!

lxe commented Dec 23, 2014

Uh oh!

bnoordhuis commented Dec 23, 2014

Uh oh!

lxe commented Dec 23, 2014

Uh oh!

bnoordhuis Dec 24, 2014

Uh oh!

bnoordhuis commented Dec 24, 2014

Uh oh!

lxe commented Dec 25, 2014

Uh oh!

bnoordhuis commented Dec 30, 2014

Uh oh!

lxe commented Dec 30, 2014

Uh oh!

bnoordhuis commented Dec 30, 2014

Uh oh!

lxe commented Dec 30, 2014

Uh oh!

rvagg commented Jan 2, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

module: force require('process') to return a reference to process by lxe · Pull Request #206 · nodejs/node · GitHub

Repository navigation

module: force require('process') to return a reference to process - #206

module: force require('process') to return a reference to process#206lxe wants to merge 1 commit intonodejs:v0.12nodejs/node:v0.12from lxe:require-processlxe/node:require-processCopy head branch name to clipboard

Conversation

lxe commented Dec 23, 2014

Uh oh!

vkurchatkin commented Dec 23, 2014

Uh oh!

lxe commented Dec 23, 2014

Uh oh!

bnoordhuis commented Dec 23, 2014

Uh oh!

lxe commented Dec 23, 2014

Uh oh!

bnoordhuis Dec 24, 2014

Choose a reason for hiding this comment

Uh oh!

bnoordhuis commented Dec 24, 2014

Uh oh!

lxe commented Dec 25, 2014

Uh oh!

bnoordhuis commented Dec 30, 2014

Uh oh!

lxe commented Dec 30, 2014

Uh oh!

bnoordhuis commented Dec 30, 2014

Uh oh!

lxe commented Dec 30, 2014

Uh oh!

rvagg commented Jan 2, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

module: force require('process') to return a reference to process#206
lxe wants to merge 1 commit into
nodejs:v0.12from
lxe:require-process