FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: cherry-pick 6989b3f6d7 from V8 upstream by TimothyGu · Pull Request #20826 · nodejs/node · GitHub

/ node Public

deps: cherry-pick 6989b3f6d7 from V8 upstream - #20826

Merged
TimothyGu merged 1 commit into
nodejs:masterfrom
TimothyGu:intl-default-lang
May 25, 2018
ConversationCommits (1)ChecksFiles changed
Merged

deps: cherry-pick 6989b3f6d7 from V8 upstream#20826
TimothyGu merged 1 commit into
nodejs:masterfrom
TimothyGu:intl-default-lang

Conversation

TimothyGu commented May 18, 2018

Copy link
Copy Markdown
Member

Original commit message:

Fix default Intl language tag handling

With certain ICU data bundles (such as the Node.js "small-icu"),
%GetDefaultICULocale() may return a more specific language tag (e.g.
"en-US") than what's available (e.g. "en"). In those cases, consider the
more specific language tag supported.

This CL also resolves the following Node.js issue:
   https://github.com/nodejs/node/issues/15223

Bug: v8:7024
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Change-Id: Ifda0776b3418734d5caa8af4e50c17cda95add73
Reviewed-on: https://chromium-review.googlesource.com/668350
Commit-Queue: Daniel Ehrenberg <littledan@chromium.org>
Reviewed-by: Daniel Ehrenberg <littledan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52716}

Refs: v8/v8@6989b3f
Fixes: #15223

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label May 18, 2018

TimothyGu commented May 18, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/14965/

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1375/

richardlau reviewed May 18, 2018
View reviewed changes

richardlau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think 'v8_embedder_string' in common.gypi should be bumped for cherry picks?

TimothyGu commented May 18, 2018

Copy link
Copy Markdown
Member Author

@richardlau Oops, forgot to push. Done.

TimothyGu force-pushed the intl-default-lang branch from 9b00714 to f734ffe Compare May 18, 2018 19:14

richardlau commented May 18, 2018

Copy link
Copy Markdown
Member

cc @nodejs/v8-update (is this correct? the guide says to cc the parent team).

TimothyGu commented May 18, 2018

Copy link
Copy Markdown
Member Author

This is the first time I've ever done something like this, so my apologies if I did anything wrong.

I've commented on the V8 issue as well, requesting a merge into 6.6. I suppose if that happens then we can just roll V8 instead of merging this PR.

apapirovski approved these changes May 22, 2018
View reviewed changes

apapirovski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Awesome, glad to see this landed on the V8 side.

TimothyGu commented May 23, 2018

Copy link
Copy Markdown
Member Author

No movement on the V8 bug tracker, so I'd move forward assuming that nothing is going to happen. @nodejs/v8-update I'll be applying this in two days.

bnoordhuis approved these changes May 23, 2018
View reviewed changes

bnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Not 100% clear to me why two of the V8 buildbots failed though. Does that also happen with master?

jasnell commented May 23, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

running CI again, to be safe: https://ci.nodejs.org/job/node-test-pull-request/15056/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1381/

jasnell commented May 23, 2018

Copy link
Copy Markdown
Member

@nodejs/build ... any ideas on what's happening with the v8 build bots? https://ci.nodejs.org/job/node-test-commit-v8-linux/1381/nodes=ppcle-ubuntu1404,v8test=v8test/console

richardlau commented May 23, 2018

Copy link
Copy Markdown
Member

Maybe nodejs/build#1205?

deps: cherry-pick 6989b3f6d7 from V8 upstream
64bed08 
Original commit message:
  Fix default Intl language tag handling

  With certain ICU data bundles (such as the Node.js "small-icu"),
  %GetDefaultICULocale() may return a more specific language tag (e.g.
  "en-US") than what's available (e.g. "en"). In those cases, consider the
  more specific language tag supported.

  This CL also resolves the following Node.js issue:
     nodejs#15223

  Bug: v8:7024
  Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
  Change-Id: Ifda0776b3418734d5caa8af4e50c17cda95add73
  Reviewed-on: https://chromium-review.googlesource.com/668350
  Commit-Queue: Daniel Ehrenberg <littledan@chromium.org>
  Reviewed-by: Daniel Ehrenberg <littledan@chromium.org>
  Cr-Commit-Position: refs/heads/master@{nodejs#52716}

Refs: v8/v8@6989b3f
Fixes: nodejs#15223
TimothyGu force-pushed the intl-default-lang branch from f734ffe to 64bed08 Compare May 25, 2018 19:13

TimothyGu commented May 25, 2018

Copy link
Copy Markdown
Member Author

One more regular CI: https://ci.nodejs.org/job/node-test-pull-request/15098/

TimothyGu merged commit 64bed08 into nodejs:master May 25, 2018

TimothyGu commented May 25, 2018

Copy link
Copy Markdown
Member Author

Landed in 8fac1d9.

TimothyGu deleted the intl-default-lang branch May 25, 2018 20:09
TimothyGu added a commit to TimothyGu/node that referenced this pull request May 25, 2018
deps: cherry-pick 6989b3f6d7 from V8 upstream
8fac1d9 
Original commit message:
  Fix default Intl language tag handling

  With certain ICU data bundles (such as the Node.js "small-icu"),
  %GetDefaultICULocale() may return a more specific language tag (e.g.
  "en-US") than what's available (e.g. "en"). In those cases, consider the
  more specific language tag supported.

  This CL also resolves the following Node.js issue:
     nodejs#15223

  Bug: v8:7024
  Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
  Change-Id: Ifda0776b3418734d5caa8af4e50c17cda95add73
  Reviewed-on: https://chromium-review.googlesource.com/668350
  Commit-Queue: Daniel Ehrenberg <littledan@chromium.org>
  Reviewed-by: Daniel Ehrenberg <littledan@chromium.org>
  Cr-Commit-Position: refs/heads/master@{nodejs#52716}

PR-URL: nodejs#20826
Fixes: nodejs#15223
Refs: v8/v8@6989b3f
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos pushed a commit that referenced this pull request May 25, 2018
deps: cherry-pick 6989b3f6d7 from V8 upstream
efc7f91 
Original commit message:
  Fix default Intl language tag handling

  With certain ICU data bundles (such as the Node.js "small-icu"),
  %GetDefaultICULocale() may return a more specific language tag (e.g.
  "en-US") than what's available (e.g. "en"). In those cases, consider the
  more specific language tag supported.

  This CL also resolves the following Node.js issue:
     #15223

  Bug: v8:7024
  Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
  Change-Id: Ifda0776b3418734d5caa8af4e50c17cda95add73
  Reviewed-on: https://chromium-review.googlesource.com/668350
  Commit-Queue: Daniel Ehrenberg <littledan@chromium.org>
  Reviewed-by: Daniel Ehrenberg <littledan@chromium.org>
  Cr-Commit-Position: refs/heads/master@{#52716}

PR-URL: #20826
Fixes: #15223
Refs: v8/v8@6989b3f
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins mentioned this pull request May 29, 2018
Merged
targos pushed a commit to targos/node that referenced this pull request May 31, 2018
deps: cherry-pick 6989b3f6d7 from V8 upstream
4b5b1a9 
Original commit message:
  Fix default Intl language tag handling

  With certain ICU data bundles (such as the Node.js "small-icu"),
  %GetDefaultICULocale() may return a more specific language tag (e.g.
  "en-US") than what's available (e.g. "en"). In those cases, consider the
  more specific language tag supported.

  This CL also resolves the following Node.js issue:
     nodejs#15223

  Bug: v8:7024
  Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
  Change-Id: Ifda0776b3418734d5caa8af4e50c17cda95add73
  Reviewed-on: https://chromium-review.googlesource.com/668350
  Commit-Queue: Daniel Ehrenberg <littledan@chromium.org>
  Reviewed-by: Daniel Ehrenberg <littledan@chromium.org>
  Cr-Commit-Position: refs/heads/master@{nodejs#52716}

PR-URL: nodejs#20826
Fixes: nodejs#15223
Refs: v8/v8@6989b3f
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
devsnek mentioned this pull request May 31, 2018
Closed
MylesBorins pushed a commit that referenced this pull request Jun 1, 2018
deps: cherry-pick 6989b3f6d7 from V8 upstream
a60ab57 
Original commit message:
  Fix default Intl language tag handling

  With certain ICU data bundles (such as the Node.js "small-icu"),
  %GetDefaultICULocale() may return a more specific language tag (e.g.
  "en-US") than what's available (e.g. "en"). In those cases, consider the
  more specific language tag supported.

  This CL also resolves the following Node.js issue:
     #15223

  Bug: v8:7024
  Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
  Change-Id: Ifda0776b3418734d5caa8af4e50c17cda95add73
  Reviewed-on: https://chromium-review.googlesource.com/668350
  Commit-Queue: Daniel Ehrenberg <littledan@chromium.org>
  Reviewed-by: Daniel Ehrenberg <littledan@chromium.org>
  Cr-Commit-Position: refs/heads/master@{#52716}

PR-URL: #20826
Fixes: #15223
Refs: v8/v8@6989b3f
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Jun 1, 2018
deps: cherry-pick 6989b3f6d7 from V8 upstream
35d6661 
Original commit message:
  Fix default Intl language tag handling

  With certain ICU data bundles (such as the Node.js "small-icu"),
  %GetDefaultICULocale() may return a more specific language tag (e.g.
  "en-US") than what's available (e.g. "en"). In those cases, consider the
  more specific language tag supported.

  This CL also resolves the following Node.js issue:
     #15223

  Bug: v8:7024
  Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
  Change-Id: Ifda0776b3418734d5caa8af4e50c17cda95add73
  Reviewed-on: https://chromium-review.googlesource.com/668350
  Commit-Queue: Daniel Ehrenberg <littledan@chromium.org>
  Reviewed-by: Daniel Ehrenberg <littledan@chromium.org>
  Cr-Commit-Position: refs/heads/master@{#52716}

PR-URL: #20826
Fixes: #15223
Refs: v8/v8@6989b3f
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins mentioned this pull request Jun 6, 2018
Merged

MylesBorins commented Aug 7, 2018

Copy link
Copy Markdown
Contributor

I've backported this to v8.x... please lmk if this is a mistake

MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
deps: cherry-pick 6989b3f6d7 from V8 upstream
bb1e8a6 
Original commit message:
  Fix default Intl language tag handling

  With certain ICU data bundles (such as the Node.js "small-icu"),
  %GetDefaultICULocale() may return a more specific language tag (e.g.
  "en-US") than what's available (e.g. "en"). In those cases, consider the
  more specific language tag supported.

  This CL also resolves the following Node.js issue:
     #15223

  Bug: v8:7024
  Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
  Change-Id: Ifda0776b3418734d5caa8af4e50c17cda95add73
  Reviewed-on: https://chromium-review.googlesource.com/668350
  Commit-Queue: Daniel Ehrenberg <littledan@chromium.org>
  Reviewed-by: Daniel Ehrenberg <littledan@chromium.org>
  Cr-Commit-Position: refs/heads/master@{#52716}

PR-URL: #20826
Fixes: #15223
Refs: v8/v8@6989b3f
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins commented Aug 7, 2018

Copy link
Copy Markdown
Contributor

backport landed cleanly but it caused tests to break

https://ci.nodejs.org/job/node-test-commit-v8-linux/1580/nodes=ppcle-ubuntu1404,v8test=v8test/testReport/junit/(root)/v8tests/mjsunit_regress_regress_6288___nohard_abort/

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

richardlau richardlau left review comments
bnoordhuis bnoordhuis approved these changes
jasnell jasnell approved these changes
targos Awaiting requested review from targos
MylesBorins Awaiting requested review from MylesBorins
ofrobots Awaiting requested review from ofrobots
+1 more reviewer
apapirovski apapirovski approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Intl.NumberFormat changed behavior (possibly after ICU 58 -> 59 bump)

7 participants

Back | FazBrowse Home | New Git URL