docs: be specific about the unit of maxBuffer - #209
Closed
timruffles wants to merge 1 commit into
Closed
timruffles wants to merge 1 commit into
timruffles wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Please wrap lines at 80 columns. Apart from that, LGTM. If you update the PR, and maybe amend the commit log so it's not a one-liner, I'll land it. |
Sorry, something went wrong.
timruffles
force-pushed
the
doc-max-buffer
branch
2 times, most recently
from
be31479 to
5eb984f
Compare
December 29, 2014 19:03
the maxBuffer option was not self-documenting, so document unit and its effect.
timruffles
force-pushed
the
doc-max-buffer
branch
from
5eb984f to
53a2cb1
Compare
December 29, 2014 19:04
Copy link
Copy Markdown
Contributor
Author
|
Done |
Sorry, something went wrong.
bnoordhuis
pushed a commit
to bnoordhuis/io.js
that referenced
this pull request
Dec 30, 2014
The maxBuffer option was not self-documenting, so document the unit and its effect. PR-URL: nodejs#209 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This was referenced Sep 23, 2021
This was referenced Jan 12, 2022
This was referenced Feb 14, 2023
syg
pushed a commit
to syg/node
that referenced
this pull request
May 5, 2025
Isolate::AttachCppHeap is about to be deprecated soon, the CppHeap should be provided during Isolate initialization instead.
bakkot
pushed a commit
to bakkot/node
that referenced
this pull request
May 11, 2026
Isolate::AttachCppHeap is about to be deprecated soon, the CppHeap should be provided during Isolate initialization instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's nice to be specific about units in docs.