doc: make minor improvements to fs.realpath() docs - #20953
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Make canonical vs. unique text more precise and eliminate quotation marks. Remove repeated text from fs.realpathSync(), linking to fs.realpath() instead.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
richardlau
reviewed
May 25, 2018
Comment thread
doc/api/fs.md
|
|
||
| If `path` resolves to a socket or a pipe, the function will return a system | ||
| dependent name for that object. | ||
| Synchronous version of [`fs.realpath()`][]. Returns the resolved pathname. |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This is almost but not quite reversing #17059. (Not objecting, just pointing out.)
Sorry, something went wrong.
BridgeAR
approved these changes
May 25, 2018
Copy link
Copy Markdown
Member
Author
|
@nodejs/documentation @nodejs/fs |
Sorry, something went wrong.
vsemozhetbyt
approved these changes
May 28, 2018
vsemozhetbyt
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Format-wise LGTM.
Sorry, something went wrong.
jasnell
approved these changes
May 29, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 30, 2018
Make canonical vs. unique text more precise and eliminate quotation marks. Remove repeated text from fs.realpathSync(), linking to fs.realpath() instead. PR-URL: nodejs#20953 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
May 31, 2018
Make canonical vs. unique text more precise and eliminate quotation marks. Remove repeated text from fs.realpathSync(), linking to fs.realpath() instead. PR-URL: #20953 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make canonical vs. unique text more precise and eliminate quotation
marks. Remove repeated text from fs.realpathSync(), linking to
fs.realpath() instead.
Checklist