FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: document current release procedure by rvagg · Pull Request #2099 · nodejs/node · GitHub

/ node Public

doc: document current release procedure - #2099

Merged
rvagg merged 1 commit into
nodejs:masterfrom
rvagg:new-release
Jul 7, 2015
ConversationCommits (1)ChecksFiles changed
Merged

doc: document current release procedure#2099
rvagg merged 1 commit into
nodejs:masterfrom
rvagg:new-release

Conversation

rvagg commented Jul 3, 2015

Copy link
Copy Markdown
Member

mscdex added the doc Issues and PRs related to the documentations. label Jul 3, 2015
chrisdickinson reviewed Jul 3, 2015
View reviewed changes
Comment thread doc/releases.md

chrisdickinson Jul 3, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I know this is a tiny thing, but we should probably make a script for it. I know I've definitely messed this up in subtle ways before.

rvagg Jul 4, 2015

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

agreed, and I messed up the tag comment for 2.3.3 today as well, this could either be Jenkinsised or put into a script but I don't see an obvious path yet

rvagg commented Jul 4, 2015

Copy link
Copy Markdown
Member Author

so much feedback, thanks folks, pushed a new version, ptal

Fishrock123 reviewed Jul 6, 2015
View reviewed changes
Comment thread doc/releases.md Outdated

Fishrock123 Jul 6, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

latest/ changelog has two spaces.

Fishrock123 commented Jul 6, 2015

Copy link
Copy Markdown
Contributor

LGTM minus one nit

doc: document current release procedure
84b3915 
PR-URL: nodejs#2099
Author: Jeremiah Senkpiel <fishrock123@rocketmail.com>
rvagg merged commit 84b3915 into nodejs:master Jul 7, 2015
rvagg deleted the new-release branch July 7, 2015 02:33

rvagg commented Jul 7, 2015

Copy link
Copy Markdown
Member Author

84b3915 merged, thanks folks

Fishrock123 mentioned this pull request Jul 9, 2015
Merged
mscdex pushed a commit to mscdex/io.js that referenced this pull request Jul 9, 2015
doc: document current release procedure
d781aca 
PR-URL: nodejs#2099
Author: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL