src: add node_process.cc by jasnell · Pull Request #21105 · nodejs/node · GitHub

Begin moving process object function definitions out of
node.cc ... continuing the process of making node.cc
smaller and easier to maintain.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

CI: https://ci.nodejs.org/job/node-test-pull-request/15232/

rubber stamp lgtm

👍 👍

LGTM, but this will need a non-trivial rebase against #20876 and quick backports against other release lines ¯\_(ツ)_/¯

@addaleax ... when are you expecting to get #20876 landed? I can hold off on landing this one until after that one goes.

@jasnell It’s labelled tsc-agenda, so I don’t think we can do it before the meeting, but by the end of the week should be doable. (The macOS CI failure over there is real but I’m optimistic about taking care of that.)

Awesome. 🎉

RSLGTM

@jasnell This is ready for rebasing now :)

Awesome. Will try to rebase tomorrow

Begin moving `process` object function definitions out of `node.cc` ... continuing the process of making `node.cc` smaller and easier to maintain.

@addaleax ... rebased! PTAL

New CI: https://ci.nodejs.org/job/node-test-pull-request/15375/

Some related failures in CI... trying again: https://ci.nodejs.org/job/node-test-pull-request/15377/

One flaky failure in Linux... re-running https://ci.nodejs.org/job/node-test-commit-linux/19468/

CI again: https://ci.nodejs.org/job/node-test-pull-request/15386/

And again: https://ci.nodejs.org/job/node-test-pull-request/15387/

(Related: Consider approving #21251.)

Begin moving `process` object function definitions out of `node.cc` ... continuing the process of making `node.cc` smaller and easier to maintain. PR-URL: #21105 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Landed in baadc7a

(note... landed this initially without metadata, caught it, then did a quick force push with the metadata... how? you ask, I forgot to node land --amend after rebasing out a squash commit)

@jasnell Have you tried adding -x "node land --amend" to the rebase command? git node should suggest that now, it will add an exec node land --amend line for each commit in the interactive rebase session.

Maybe nodejs/node-core-utils#160 could help with that as well

@jasnell would you be able to backport this to v10.x-staging asap? It probably has to be done from scratch instead of a cherry-pick to avoid sneaking in semver-major changes.

@targos Are you still planning on merging the Worker changes into v10.x in the near future? I think they might have a tiny conflict with one of the patches in the security release – but a big one with this PR

(i.e. I’d recommend doing this after the Worker PR – if there are nontrivial merge conflicts, I’m happy to help)

I've already merged everything from master apart from this PR, including de Worker changes

Will do a backport PR early next week.

Ping @jasnell

Ping. Does anyone want to pick this up?

Ping. Commits that depend on this change are accumulating.

I'll be able to get back on backporting this week.

Super. Thank you!

Backport of nodejs#21105

Begin moving `process` object function definitions out of `node.cc` ... continuing the process of making `node.cc` smaller and easier to maintain. PR-URL: nodejs#21105 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Begin moving `process` object function definitions out of `node.cc` ... continuing the process of making `node.cc` smaller and easier to maintain. PR-URL: #21105 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Backport-PR-URL: #21799 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Begin moving `process` object function definitions out of `node.cc` ... continuing the process of making `node.cc` smaller and easier to maintain. Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Backport-PR-URL: #21798 PR-URL: #21105

nodejs-github-bot added build Issues and PRs related to build files or the CI. c++ Issues and PRs that require attention from people who are familiar with C++. labels Jun 3, 2018

jasnell requested a review from addaleax June 3, 2018 00:35

jasnell added the process Issues and PRs related to the process subsystem. label Jun 3, 2018

devsnek approved these changes Jun 3, 2018

View reviewed changes

refack approved these changes Jun 3, 2018

View reviewed changes

trivikr approved these changes Jun 3, 2018

View reviewed changes

evanlucas approved these changes Jun 10, 2018

View reviewed changes

src: add node_process.cc

c87f004

Begin moving `process` object function definitions out of `node.cc` ... continuing the process of making `node.cc` smaller and easier to maintain.

jasnell force-pushed the add-node-process-cc branch from 39bfa5f to c87f004 Compare June 10, 2018 21:32

[Squash] fix compile err

2b928c3

joyeecheung approved these changes Jun 11, 2018

View reviewed changes

jasnell closed this Jun 14, 2018

targos added the backport-requested-v10.x label Jun 15, 2018

This was referenced Jun 19, 2018

process: implement process.hrtime.bigint() #21256

Closed

src: remove .h if -inl.h is already included #21381

Closed

targos mentioned this pull request Jun 26, 2018

src: start annotating native code side effect #21458

Closed

2 tasks

jasnell added a commit to jasnell/node that referenced this pull request Jul 13, 2018

src: add node_process.cc

f367b4d

Backport of nodejs#21105

jasnell mentioned this pull request Jul 13, 2018

[8.x] backport node.cc changes #21798

Closed

2 tasks

jasnell mentioned this pull request Jul 13, 2018

[10.x] backport src: add node_process.cc #21799

Closed

2 tasks

targos added backported-to-v10.x and removed backport-requested-v10.x labels Jul 14, 2018

targos mentioned this pull request Jul 17, 2018

v10.7.0 proposal #21851

Merged

MylesBorins added the backported-to-v8.x label Aug 1, 2018

MylesBorins mentioned this pull request Aug 16, 2018

v8.12.0 proposal #21593

Merged

src: add node_process.cc by jasnell · Pull Request #21105 · nodejs/node · GitHub

Uh oh!

Uh oh!

src: add node_process.cc - #21105

src: add node_process.cc#21105jasnell wants to merge 2 commits intonodejs:masternodejs/node:masterfrom jasnell:add-node-process-ccjasnell/node:add-node-process-ccCopy head branch name to clipboard

Conversation

jasnell commented Jun 3, 2018

Checklist

Uh oh!

jasnell commented Jun 3, 2018

Uh oh!

devsnek left a comment

Choose a reason for hiding this comment

Uh oh!

refack left a comment

Choose a reason for hiding this comment

Uh oh!

addaleax commented Jun 3, 2018

Uh oh!

jasnell commented Jun 3, 2018

Uh oh!

addaleax commented Jun 3, 2018

Uh oh!

jasnell commented Jun 3, 2018

Uh oh!

trivikr left a comment

Choose a reason for hiding this comment

Uh oh!

addaleax commented Jun 7, 2018

Uh oh!

jasnell commented Jun 7, 2018

Uh oh!

jasnell commented Jun 10, 2018

Uh oh!

jasnell commented Jun 10, 2018

Uh oh!

jasnell commented Jun 11, 2018

Uh oh!

Trott commented Jun 11, 2018

Uh oh!

Trott commented Jun 11, 2018

Uh oh!

jasnell commented Jun 14, 2018

Uh oh!

jasnell commented Jun 14, 2018

Uh oh!

joyeecheung commented Jun 15, 2018

Uh oh!

targos commented Jun 15, 2018

Uh oh!

addaleax commented Jun 15, 2018

Uh oh!

targos commented Jun 15, 2018

Uh oh!

jasnell commented Jun 15, 2018

Uh oh!

targos commented Jun 22, 2018

Uh oh!

targos commented Jul 3, 2018

Uh oh!

targos commented Jul 10, 2018

Uh oh!

jasnell commented Jul 10, 2018

Uh oh!

targos commented Jul 10, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

src: add node_process.cc#21105
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:add-node-process-cc