build: bail early if clean is invoked - #2127
Closed
jbergstroem wants to merge 1 commit into
Closed
jbergstroem wants to merge 1 commit into
jbergstroem wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
On windows, there's no need to continue with the msbuild process (signing, whatnot) when we only want to clean the project.
Copy link
Copy Markdown
Member
Author
|
..suggesting we invoke make clean and vcbuild.bat clean as part of shutting down a job in jenkins. Will help us with situations where build slaves runs into out of disk situations. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
jbergstroem
added a commit
that referenced
this pull request
Jul 10, 2015
On windows, there's no need to continue with the msbuild process (signing, whatnot) when we only want to clean the project. PR-URL: #2127 Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
Copy link
Copy Markdown
Member
Author
|
Merged in 47e2c5c. Thanks for the review. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On windows, there's no need to continue with the msbuild process (signing, whatnot) when we only want to clean the project.
/R=@nodejs/build