test: add missing crypto checks - #2129
Closed
jbergstroem wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Add a check for crypto before using it, similar to how other tests work.
Copy link
Copy Markdown
Contributor
|
I wrote these tests and missed to add the checks. Thanks for catching. LGTM. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
jbergstroem
added a commit
that referenced
this pull request
Jul 8, 2015
Add a check for crypto before using it, similar to how other tests work. PR-URL: #2129 Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Copy link
Copy Markdown
Member
Author
|
Merged in 2ba1740. Thanks for the review. |
Sorry, something went wrong.
mscdex
pushed a commit
to mscdex/io.js
that referenced
this pull request
Jul 9, 2015
Add a check for crypto before using it, similar to how other tests work. PR-URL: nodejs#2129 Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a check for crypto before using it, similar to how other tests work.
Guess my previous commit ("Refactor all tests that depends on crypto", 671fbd5) wasn't accurate 🐼
/R=@shigeki? (you reviewed last time)