dgram: return self on .bind() and .close() - #214
Closed
brendanashworth wants to merge 2 commits into
Closed
brendanashworth wants to merge 2 commits into
brendanashworth wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM but can you make the commit log conform to the convention? See CONTRIBUTING.md or git log lib/dgram.js for examples. |
Sorry, something went wrong.
This commit changes `lib/dgram.js` Sockets to, when they are bound to a port / IP, return themselves. This is done in order to allow chaining of methods and be in accordance with the `lib/net.js` library.
This commit adds a return statement to the dgram.Socket.close() function that returns itself after it finishes. This follows along the functionality of the more popular and, dare I say, father-library `lib/net.js`.
brendanashworth
force-pushed
the
dgram-return-self
branch
from
f2207da to
6a2f4b5
Compare
December 29, 2014 21:39
Copy link
Copy Markdown
Contributor
Author
|
@bnoordhuis I think its fixed! |
Sorry, something went wrong.
bnoordhuis
pushed a commit
to bnoordhuis/io.js
that referenced
this pull request
Dec 30, 2014
This commit changes `lib/dgram.js` Sockets to, when they are bound to a port / IP, return themselves. This is done in order to allow chaining of methods and be in accordance with the `lib/net.js` library. PR-URL: nodejs#214 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
bnoordhuis
pushed a commit
to bnoordhuis/io.js
that referenced
this pull request
Dec 30, 2014
This commit adds a return statement to the dgram.Socket.close() function that returns itself after it finishes. This follows along the functionality of the more popular and, dare I say, father-library `lib/net.js`. PR-URL: nodejs#214 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This was referenced Sep 23, 2021
This was referenced Jan 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These commits add two functionalities to the lib/dgram.js library: a datagram Socket should return itself when it is both closed and bound to a host.
This can be used for better chaining of functions, i.e.:
I ran across this when I was working with the datagram module and chained it like above ^, expecting it to behave like the net module does. These two commits basically make it function like the net module now.
> var net = require('net'); var dgram = require('dgram'); undefined > var server = net.createServer(function() {}); undefined > var socket = dgram.createSocket('udp4'); undefined > server.listen(8124) == server; true > socket.bind(8124) == socket; falseI also added tests, I hope those tests are satisfactory, and should this be merged into io.js I'll send a PR into node.js.