FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: move net bytes-per-chunk test to sequential by Trott · Pull Request #21457 · nodejs/node · GitHub

/ node Public

test: move net bytes-per-chunk test to sequential - #21457

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:sorry-overhead
Closed

test: move net bytes-per-chunk test to sequential#21457
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:sorry-overhead

Conversation

Trott commented Jun 22, 2018

Copy link
Copy Markdown
Member

The test is timing out on FreeBSD 10 in CI. It takes less than half as
long to run when it is in sequential on that platform instead of
parallel.

Refs: #21322 (comment)

Use 👍 reaction here to fast-track.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

The test is timing out on FreeBSD 10 in CI. It takes less than half as
long to run when it is in sequential on that platform instead of
parallel.

Refs: nodejs#21322 (comment)
Trott added flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Jun 22, 2018

Copy link
Copy Markdown
Collaborator

nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 22, 2018

Trott commented Jun 22, 2018

Copy link
Copy Markdown
Member Author

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 22, 2018

Trott commented Jun 22, 2018

Copy link
Copy Markdown
Member Author

CI is green.

targos commented Jun 24, 2018

Copy link
Copy Markdown
Member

Landed in 1ee4703

targos closed this Jun 24, 2018
targos pushed a commit that referenced this pull request Jun 24, 2018
The test is timing out on FreeBSD 10 in CI. It takes less than half as
long to run when it is in sequential on that platform instead of
parallel.

Refs: #21322 (comment)

PR-URL: #21457
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jun 24, 2018
The test is timing out on FreeBSD 10 in CI. It takes less than half as
long to run when it is in sequential on that platform instead of
parallel.

Refs: #21322 (comment)

PR-URL: #21457
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Jul 3, 2018
Trott deleted the sorry-overhead branch January 13, 2022 22:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL