path: assert path.join() arguments equally - #2159
Closed
phillipj wants to merge 1 commit into
Closed
phillipj wants to merge 1 commit into
phillipj wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Re-use `assertPath()` when asserting path argument types in `join()` as throughout the rest of the `path` module. This also ensures the same error message generated for posix as for win32. PR-URL: nodejs#2159
phillipj
force-pushed
the
path-join-assert
branch
from
c9a8f82 to
335be47
Compare
July 10, 2015 22:28
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM. Hope we are not breaking any tests. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
All tests pass :) The existing tests ensures there's an TypeError thrown on invalid input, no assertions on the message itself. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Hah, lets hope it lands this time then @thefourtheye :) |
Sorry, something went wrong.
silverwind
pushed a commit
that referenced
this pull request
Jul 11, 2015
Re-use `assertPath()` when asserting path argument types in `join()` as throughout the rest of the `path` module. This also ensures the same error message generated for posix as for win32. PR-URL: #2159 Reviewed-By: Roman Reiss <me@silverwind.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-use assertPath() when asserting path argument types in join() as throughout the rest of the path module.
This also ensures the same error message generated for posix as for win32.