FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: remove "note that" from fs doc by Trott · Pull Request #21646 · nodejs/node · GitHub

/ node Public

doc: remove "note that" from fs doc - #21646

Closed
Trott wants to merge 4 commits into
nodejs:masterfrom
Trott:noted
ConversationCommits (4)ChecksFiles changed
Closed

doc: remove "note that" from fs doc#21646
Trott wants to merge 4 commits into
nodejs:masterfrom
Trott:noted

Conversation

Trott commented Jul 3, 2018

Copy link
Copy Markdown
Member

Remove "note that" from the fs documentation, along with other minor
nearby improvements.

Before:

Note that some characters are obscured by Strong Bad's head.

After:

Some characters are obscured by Strong Bad's head.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot commented Jul 3, 2018

Copy link
Copy Markdown
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/207/pipeline

nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Jul 3, 2018
ChALkeR approved these changes Jul 4, 2018
View reviewed changes
Comment thread doc/api/fs.md Outdated

ChALkeR Jul 4, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nit: I don't think brackets around the last sentance are needed, also.

Trott Jul 5, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Brackets removed. Thanks!

Comment thread doc/api/fs.md Outdated

ChALkeR Jul 4, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nit: can fit on three lines:

  // Will print something similar to `/tmpabc123`.
  // A new temporary directory is created at the file system root
  // rather than *within* the /tmp directory.

Trott Jul 5, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Wrapped and reduced to 3 lines. Thanks.

vsemozhetbyt reviewed Jul 4, 2018
View reviewed changes
Comment thread doc/api/fs.md Outdated

vsemozhetbyt Jul 4, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

`fs.write` -> `fs.write()`?

Trott Jul 5, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This and the other similar nit below addressed. Thanks!

vsemozhetbyt reviewed Jul 4, 2018
View reviewed changes
Comment thread doc/api/fs.md Outdated

vsemozhetbyt Jul 4, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

`fs.write` -> `fs.write()`?

doc: remove "note that" from fs doc
78911e7 
Remove "note that" from the fs documentation, along with other minor
nearby improvements.

Before:

    Note that some characters are obscured by Strong Bad's head.

After:

    Some characters are obscured by Strong Bad's head.

Trott commented Jul 5, 2018

Copy link
Copy Markdown
Member Author

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/900/

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jul 5, 2018
mhdawson approved these changes Jul 5, 2018
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Trott commented Jul 6, 2018

Copy link
Copy Markdown
Member Author

Landed in f545ae9

Trott closed this Jul 6, 2018
Trott added a commit to Trott/io.js that referenced this pull request Jul 6, 2018
doc: remove "note that" from fs doc
f545ae9 
Remove "note that" from the fs documentation, along with other minor
nearby improvements.

Before:

    Note that some characters are obscured by Strong Bad's head.

After:

    Some characters are obscured by Strong Bad's head.

PR-URL: nodejs#21646
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos pushed a commit that referenced this pull request Jul 6, 2018
doc: remove "note that" from fs doc
04eed23 
Remove "note that" from the fs documentation, along with other minor
nearby improvements.

Before:

    Note that some characters are obscured by Strong Bad's head.

After:

    Some characters are obscured by Strong Bad's head.

PR-URL: #21646
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos mentioned this pull request Jul 17, 2018
Merged
This was referenced Jul 18, 2018
Closed
Closed
Closed
Closed
Closed
vsemozhetbyt mentioned this pull request Aug 2, 2019
Closed
2 tasks
Trott deleted the noted branch January 13, 2022 22:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ChALkeR ChALkeR approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
trivikr trivikr approved these changes
+2 more reviewers
mhdawson mhdawson approved these changes
vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL