FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix some descriptions of sync methods by timruffles · Pull Request #21747 · nodejs/node · GitHub

/ node Public

doc: fix some descriptions of sync methods - #21747

Closed
timruffles wants to merge 2 commits into
nodejs:masterfrom
timruffles:patch-2
ConversationCommits (2)ChecksFiles changed
Closed

doc: fix some descriptions of sync methods#21747
timruffles wants to merge 2 commits into
nodejs:masterfrom
timruffles:patch-2

Conversation

timruffles commented Jul 11, 2018

Copy link
Copy Markdown
Contributor
Checklist

nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Jul 11, 2018

mscdex commented Jul 11, 2018

Copy link
Copy Markdown
Contributor

The prefix in the commit message should be doc: instead of fs:.

maclover7 approved these changes Jul 11, 2018
View reviewed changes

maclover7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/250/

vsemozhetbyt commented Jul 11, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

It seems the same issue can be fixed in the fs.readlinkSync() and fs.realpathSync.native(). You can amend a commit or add a new commit if you please (updating the PR title).

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jul 12, 2018

BridgeAR commented Jul 12, 2018

Copy link
Copy Markdown
Member

It would be great if the other entries would be fixed as well :-)

vsemozhetbyt commented Jul 17, 2018

Copy link
Copy Markdown
Contributor

How can we proceed? Can we fix other cases on landing?

Trott commented Jul 18, 2018

Copy link
Copy Markdown
Member

How can we proceed? Can we fix other cases on landing?

@vsemozhetbyt In my opinion, any of the following are good approaches:

  • Land this and open a separate PR to fix the other two instances
  • Land this and open a new issue about the other two instances, perhaps labeling it "good first contribution"
  • Add your own commit to this branch/PR fixing the other two instances. You'll need to re-run the lite CI and it's probably a good idea to get at least one reviewer to reaffirm their approval with the additional changes.

BridgeAR changed the title fs: fix readdirSync docs, doesn't accept a callback doc: fix readdirSync docs, doesn't accept a callback Jul 18, 2018

vsemozhetbyt commented Jul 18, 2018

Copy link
Copy Markdown
Contributor

I've pushed an additional commit. Dear reviewers, PTAL.

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/915/

vsemozhetbyt changed the title doc: fix readdirSync docs, doesn't accept a callback doc: fix some descriptions of sync methods Jul 18, 2018

vsemozhetbyt commented Jul 20, 2018

Copy link
Copy Markdown
Contributor

I will land this tomorrow if there are no objections or corrections.

vsemozhetbyt pushed a commit that referenced this pull request Jul 21, 2018
doc: fix descriptions of sync methods in fs.md
2d48f97 
PR-URL: #21747
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

vsemozhetbyt commented Jul 21, 2018

Copy link
Copy Markdown
Contributor

Landed in 2d48f97
Thank you!

targos pushed a commit that referenced this pull request Jul 21, 2018
doc: fix descriptions of sync methods in fs.md
eabe907 
PR-URL: #21747
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos mentioned this pull request Jul 31, 2018
Merged
This was referenced Aug 1, 2018
Closed
Closed
Closed
This was referenced Aug 2, 2018
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
BridgeAR BridgeAR approved these changes
trivikr trivikr approved these changes
+2 more reviewers
maclover7 maclover7 approved these changes
vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL