FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tls: name anonymous function in tls.js by klacabane · Pull Request #21754 · nodejs/node · GitHub

/ node Public

tls: name anonymous function in tls.js - #21754

Closed
klacabane wants to merge 1 commit into
nodejs:masterfrom
klacabane:name-anonymous-function-dev
ConversationCommits (1)ChecksFiles changed
Closed

tls: name anonymous function in tls.js#21754
klacabane wants to merge 1 commit into
nodejs:masterfrom
klacabane:name-anonymous-function-dev

Conversation

klacabane commented Jul 11, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Refs: #8913

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot added the tls Issues and PRs related to the tls subsystem. label Jul 11, 2018

trivikr commented Jul 11, 2018

Copy link
Copy Markdown
Member

Thank you @klacabane for your first PR in Node.js core! 🎉

CI: https://ci.nodejs.org/job/node-test-pull-request/15799/

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jul 12, 2018

trivikr commented Jul 14, 2018

Copy link
Copy Markdown
Member

node-test-commit-linux re-run https://ci.nodejs.org/job/node-test-commit-linux/20101/

trivikr commented Jul 18, 2018

Copy link
Copy Markdown
Member

Landed in 07c514c

Congratulations @klacabane on your first commit in Node.js core! 🎉🎉🎉

trivikr closed this Jul 18, 2018
trivikr pushed a commit that referenced this pull request Jul 18, 2018
tls: name anonymous function in tls.js
07c514c 
Refs: #8913

PR-URL: #21754
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
targos pushed a commit that referenced this pull request Jul 19, 2018
tls: name anonymous function in tls.js
0f70017 
Refs: #8913

PR-URL: #21754
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
targos mentioned this pull request Jul 31, 2018
Merged
This was referenced Aug 1, 2018
Closed
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
BridgeAR BridgeAR approved these changes
trivikr trivikr approved these changes
+1 more reviewer
maclover7 maclover7 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL