test: pass through stderr in benchmark tests - #21860
Conversation
Sorry, something went wrong.
This helps a lot with debugging failing benchmark tests, which would otherwise just print an assertion for the exit code (something like `+1 -0`, which yields almost no information about a failure).
|
@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/297/pipeline |
Sorry, something went wrong.
Trott
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
|
@addaleax - why is the third entry (in the stdio array) required? |
Sorry, something went wrong.
|
@gireeshpunathil I’m not sure I understand – the first one is for stdin, which we don’t really care about, the second one is for stdout (which is what we’re testing here, so we need to capture it). The third one is for stderr; that’s the debugging information that should not get lost in the parent process. The fourth one is necessary for fork() to work. |
Sorry, something went wrong.
|
my apologies - I meant the 4th entry (somehow the 0 based index concept messed up with the natural language).
Can you please elaborate? missing to catch this. Is it for process.send to work properly? |
Sorry, something went wrong.
|
@gireeshpunathil I think process.send is the reason for it, but generally, it seems that child_process.fork() just fails if there’s no IPC file descriptor? I think we might be able to switch to another child_process if we like, if we want to avoid that extra fd. |
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
|
Just fixed AIX in CI (I hope): https://ci.nodejs.org/job/node-test-pull-request/16049/ |
Sorry, something went wrong.
This helps a lot with debugging failing benchmark tests, which would otherwise just print an assertion for the exit code (something like `+1 -0`, which yields almost no information about a failure). PR-URL: #21860 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
This helps a lot with debugging failing benchmark tests, which would otherwise just print an assertion for the exit code (something like `+1 -0`, which yields almost no information about a failure). PR-URL: #21860 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
This helps a lot with debugging failing benchmark tests,
which would otherwise just print an assertion for the
exit code (something like +1 -0, which yields almost no
information about a failure).
Checklist