FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v10.x] http: allow url and options to be passed to http*.request and http*.get by targos · Pull Request #21880 · nodejs/node · GitHub

/ node Public

[v10.x] http: allow url and options to be passed to http*.request and http*.get - #21880

Closed
targos wants to merge 2 commits into
nodejs:v10.x-stagingfrom
targos:backport-21616
ConversationCommits (2)ChecksFiles changed
Closed

[v10.x] http: allow url and options to be passed to http*.request and http*.get#21880
targos wants to merge 2 commits into
nodejs:v10.x-stagingfrom
targos:backport-21616

Conversation

targos commented Jul 19, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Backport of #21616

targos added the v10.x label Jul 19, 2018

nodejs-github-bot commented Jul 19, 2018

Copy link
Copy Markdown
Collaborator

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/313/pipeline

targos commented Jul 19, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/15943/
Edit: resumed build: https://ci.nodejs.org/job/node-test-pull-request/15947/

targos commented Jul 20, 2018

Copy link
Copy Markdown
Member Author

@nodejs/http

targos commented Jul 24, 2018

Copy link
Copy Markdown
Member Author

Ping

trivikr commented Jul 27, 2018

Copy link
Copy Markdown
Member

\cc @rubys

rubys added 2 commits August 2, 2018 21:58
http: allow url and options to be passed to http*.request and http*.get
4436efc 
Fixes: nodejs#20795
PR-URL: nodejs#21616
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
https: allow url and options to be passed to https.request
0c748a4 
PR-URL: nodejs#22003
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

targos commented Aug 2, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

Rebased and added #22003. PTAL.
CI: https://ci.nodejs.org/job/node-test-pull-request/16158/
Edit: rebuild https://ci.nodejs.org/job/node-test-commit-linuxone/3528/

targos added http Issues or PRs related to the http subsystem. https Issues or PRs related to the https subsystem. labels Aug 2, 2018

targos commented Aug 4, 2018

Copy link
Copy Markdown
Member Author

Ping @trivikr since I added a new commit.
Ping @rubys this backports two of your PRs.

targos commented Aug 6, 2018

Copy link
Copy Markdown
Member Author

Summoning @nodejs/collaborators. I'm desperately waiting for reviews :)

targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Aug 6, 2018
Trott approved these changes Aug 6, 2018
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Rubber-stamp LGTM

mcollina approved these changes Aug 6, 2018
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

targos pushed a commit that referenced this pull request Aug 7, 2018
http: allow url and options to be passed to http*.request and http*.get
37369eb 
Fixes: #20795
PR-URL: #21616
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ron Korving <ron@ronkorving.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Backport-PR-URL: #21880
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Aug 7, 2018
https: allow url and options to be passed to https.request
2bf9a4a 
PR-URL: #22003
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Backport-PR-URL: #21880
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

targos commented Aug 7, 2018

Copy link
Copy Markdown
Member Author

Thank you! Landed in 37369eb and 2bf9a4a

targos closed this Aug 7, 2018
targos deleted the backport-21616 branch August 7, 2018 06:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
Trott Trott approved these changes
trivikr trivikr approved these changes

Assignees

No one assigned

Labels

http Issues or PRs related to the http subsystem. https Issues or PRs related to the https subsystem. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL