FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc : Fix incorrect method name by antsmartian · Pull Request #21908 · nodejs/node · GitHub

/ node Public

doc : Fix incorrect method name - #21908

Closed
antsmartian wants to merge 1 commit into
nodejs:masterfrom
antsmartian:21904
Closed

doc : Fix incorrect method name#21908
antsmartian wants to merge 1 commit into
nodejs:masterfrom
antsmartian:21904

Conversation

antsmartian commented Jul 20, 2018
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #21904

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Copy link
Copy Markdown
Contributor

Copy link
Copy Markdown
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

vsemozhetbyt added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels Jul 20, 2018
vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 20, 2018
vsemozhetbyt pushed a commit that referenced this pull request Jul 20, 2018
PR-URL: #21908
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Copy link
Copy Markdown
Contributor

Landed in 79e63c5
Thank you!

antsmartian commented Jul 20, 2018
edited
Loading

Copy link
Copy Markdown
Contributor Author

Wow, that's so quick. Thanks everyone, cc @vsemozhetbyt .

targos pushed a commit that referenced this pull request Jul 20, 2018
PR-URL: #21908
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
antsmartian deleted the 21904 branch July 20, 2018 18:02
targos mentioned this pull request Jul 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL