FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: fixup docs and run known_issues by default by maclover7 · Pull Request #21910 · nodejs/node · GitHub

/ node Public

tools: fixup docs and run known_issues by default - #21910

Closed
maclover7 wants to merge 1 commit into
nodejs:masterfrom
maclover7:jm-test-fixup
ConversationCommits (1)ChecksFiles changed
Closed

tools: fixup docs and run known_issues by default#21910
maclover7 wants to merge 1 commit into
nodejs:masterfrom
maclover7:jm-test-fixup

Conversation

maclover7 commented Jul 20, 2018

Copy link
Copy Markdown
Contributor
  • Updates test/README.md with new suites
  • Fixes some outdated IGNORED_SUITES listings
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot commented Jul 20, 2018

Copy link
Copy Markdown
Collaborator

@maclover7 build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/322/pipeline

vsemozhetbyt added doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Jul 20, 2018
maclover7 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jul 20, 2018
Trott reviewed Jul 20, 2018
View reviewed changes
Comment thread tools/test.py Outdated

Trott Jul 20, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm surprised known_issues is in the ignore set. Any objection to removing it?

maclover7 Jul 22, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

(probably) fine with removing it, but might be best to do in a separate PR for visibility.

richardlau Jul 25, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

But if this lands then won't we stop running known_issues until the subsequent PR to remove it from this list lands?

maclover7 Jul 26, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@richardlau Ah, true -- I'll remove known_issues from the list in this PR :)

Trott approved these changes Jul 20, 2018
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, although I think we should be running known_issues, no?

maclover7 commented Jul 25, 2018

Copy link
Copy Markdown
Contributor Author

Will land this as-is, and open up a separate PR re: test/known_issues

maclover7 commented Jul 25, 2018

Copy link
Copy Markdown
Contributor Author

CI before landing: https://ci.nodejs.org/job/node-test-pull-request/16006/

Trott commented Jul 25, 2018

Copy link
Copy Markdown
Member

Nit: fixup -> fix up in commit message to keep the verb as the first word.

maclover7 changed the title doc,tools: fixup documentation tools: fixup docs and run known_issues by default Jul 26, 2018
tools: fix docs and run known_issues by default
e039bde 
- Updates `test/README.md` with new suites
- Fixes some outdated `IGNORED_SUITES` listings
- Allows for `test/known_issues` suite to be run by default

maclover7 commented Jul 26, 2018

Copy link
Copy Markdown
Contributor Author

Updated @richardlau @Trott, PTAL

richardlau approved these changes Jul 26, 2018
View reviewed changes
Comment thread test/README.md
|v8-updates |No |Tests for V8 performance integration.|

_When a new test directory is added, make sure to update the `CI_JS_SUITES`
variable in the `Makefile` and the `js_test_suites` variable in

richardlau Jul 26, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This bottom note can probably be removed too as it looks like both CI_JS_SUITES and js_test_suites are default rather than a list of test directories. This can be done in another PR if you'd rather just land this PR as-is.

maclover7 commented Jul 27, 2018

Copy link
Copy Markdown
Contributor Author

Landed in b1b2f7c, thank you for the reviews!

maclover7 closed this Jul 27, 2018
maclover7 deleted the jm-test-fixup branch July 27, 2018 00:49
maclover7 added a commit that referenced this pull request Jul 27, 2018
tools: fix docs and run known_issues by default
b1b2f7c 
- Updates `test/README.md` with new suites
- Fixes some outdated `IGNORED_SUITES` listings
- Allows for `test/known_issues` suite to be run by default

PR-URL: #21910
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added backport-requested-v10.x and removed author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Jul 31, 2018

targos commented Jul 31, 2018

Copy link
Copy Markdown
Member

Depends on #22039 to land on v10.x-staging

targos mentioned this pull request Jul 31, 2018
Closed
3 tasks
targos pushed a commit that referenced this pull request Aug 2, 2018
tools: fix docs and run known_issues by default
7a7c194 
- Updates `test/README.md` with new suites
- Fixes some outdated `IGNORED_SUITES` listings
- Allows for `test/known_issues` suite to be run by default

PR-URL: #21910
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
rvagg mentioned this pull request Aug 13, 2018
Merged
beevelop mentioned this pull request Aug 16, 2018
Closed
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
sam-github mentioned this pull request Jul 24, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
richardlau richardlau approved these changes
+2 more reviewers
lance lance approved these changes
vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL