test: provide better message for orphan output documentation - #21913
Closed
rubys wants to merge 2 commits into
Closed
test: provide better message for orphan output documentation#21913rubys wants to merge 2 commits into
rubys wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
BridgeAR
approved these changes
Jul 20, 2018
vsemozhetbyt
approved these changes
Jul 20, 2018
This comment has been minimized.
cjihrig
approved these changes
Jul 20, 2018
Copy link
Copy Markdown
Member
|
Optional additional improvement for the output: There's a not not on line 57 (line 46 in the current version of the file). I think just one not is intended. |
Sorry, something went wrong.
Trott
approved these changes
Jul 20, 2018
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
trivikr
approved these changes
Jul 22, 2018
jasnell
approved these changes
Jul 23, 2018
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 23, 2018
PR-URL: nodejs#21913 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 24, 2018
PR-URL: #21913 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Aug 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21912
Checklist