src: add missing cmath include to traced_value.cc - #21924
Conversation
Sorry, something went wrong.
|
@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/328/pipeline |
Sorry, something went wrong.
maclover7
left a comment
There was a problem hiding this comment.
LGTM, but is there a test we could add here to make sure this doesn't break? Or maybe there was a warning that was missed in CI somewhere?
Sorry, something went wrong.
|
CI: https://ci.nodejs.org/job/node-test-pull-request/15975/ @maclover7 I don't know. My guess that this went undetected because cmath was included as a transitive dependency on most systems, which makes this very hard to detect. |
Sorry, something went wrong.
|
CI failures are both known flakes, and it’s not like this change would have interacted with them in some way, but: OS X re-build: https://ci.nodejs.org/job/node-test-commit-osx/19964/ |
Sorry, something went wrong.
Fixes: #21903 PR-URL: #21924 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Fixes: #21903 PR-URL: #21924 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Fixes: #21903
Checklist