FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Define xrange() in Python 3 by cclauss · Pull Request #21945 · nodejs/node · GitHub

/ node Public

Define xrange() in Python 3 - #21945

Closed
cclauss wants to merge 1 commit into
nodejs:masterfrom
cclauss:patch-1
ConversationCommits (1)ChecksFiles changed
Closed

Define xrange() in Python 3#21945
cclauss wants to merge 1 commit into
nodejs:masterfrom
cclauss:patch-1

Conversation

cclauss commented Jul 23, 2018

Copy link
Copy Markdown
Contributor

xrange() was removed in Python 3 in favor of range(). This PR ensures similar functionality on both Python 2 and Python 3.

Discovered via https://travis-ci.com/nodejs/node/builds/79706150 (#21942)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Define xrange() in Python 3
bbec82b 
__xrange()__ was removed in Python 3 in favor of __range()__.  This PR ensures similar functionality on both Python 2 and Python 3.

Discovered via https://travis-ci.com/nodejs/node/builds/79706150 (nodejs#21942)
nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jul 23, 2018

TimothyGu commented Jul 23, 2018

Copy link
Copy Markdown
Member

Refs: google/styleguide#332

addaleax added the python PRs and issues that require attention from people who are familiar with Python. label Jul 23, 2018

addaleax commented Jul 23, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/15980/

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jul 23, 2018

addaleax commented Jul 23, 2018

Copy link
Copy Markdown
Member

By the way, your author name in this commit is given as “cclauss”. Is that intended or do you prefer to be listed (changelog, git log, AUTHORS file) with some other name? People typically prefer their full name, but ultimately it’s up to you.

cclauss commented Jul 23, 2018

Copy link
Copy Markdown
Contributor Author

cclauss is fine as the author name

cclauss commented Jul 24, 2018

Copy link
Copy Markdown
Contributor Author

I can not make sense of these error reports. Please help.

TimothyGu commented Jul 24, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

@cclauss Re-running the failed CI.

CI: https://ci.nodejs.org/job/node-test-pull-request/15999/

TimothyGu commented Jul 24, 2018

Copy link
Copy Markdown
Member

Let's try again.

https://ci.nodejs.org/job/node-test-commit-windows-fanned/19457/

TimothyGu commented Jul 25, 2018

Copy link
Copy Markdown
Member

Seems like everything passes now!

addaleax commented Jul 27, 2018

Copy link
Copy Markdown
Member

Landed in bade0fe, thanks for the contribution! 🎉

addaleax closed this Jul 27, 2018
addaleax pushed a commit that referenced this pull request Jul 27, 2018
tools: define xrange() in Python 3
bade0fe 
__xrange()__ was removed in Python 3 in favor of __range()__.
This PR ensures similar functionality on both Python 2 and Python 3.

Discovered via https://travis-ci.com/nodejs/node/builds/79706150
(#21942).

PR-URL: #21945
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
cclauss deleted the patch-1 branch July 27, 2018 19:44
targos pushed a commit that referenced this pull request Jul 31, 2018
tools: define xrange() in Python 3
ce527d9 
__xrange()__ was removed in Python 3 in favor of __range()__.
This PR ensures similar functionality on both Python 2 and Python 3.

Discovered via https://travis-ci.com/nodejs/node/builds/79706150
(#21942).

PR-URL: #21945
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Jul 31, 2018
Merged
This was referenced Aug 1, 2018
Closed
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
+1 more reviewer
TimothyGu TimothyGu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL