doc: do not advise to cancel full CI on onboarding - #21977
Closed
vsemozhetbyt wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Refs: #21938 (comment) and discussion below the comment.
Copy link
Copy Markdown
Collaborator
|
@vsemozhetbyt build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/350/pipeline |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Should we cc and label TSC for this? |
Sorry, something went wrong.
3 tasks
mmarchini
approved these changes
Jul 25, 2018
refack
approved these changes
Jul 25, 2018
richardlau
approved these changes
Jul 25, 2018
joaocgreis
approved these changes
Jul 26, 2018
maclover7
approved these changes
Jul 26, 2018
Trott
approved these changes
Jul 26, 2018
Copy link
Copy Markdown
Member
|
👍 this comment to fast-track. |
Sorry, something went wrong.
apapirovski
approved these changes
Jul 26, 2018
Copy link
Copy Markdown
Contributor
Author
|
Landed in a9f32a3 |
Sorry, something went wrong.
vsemozhetbyt
added a commit
that referenced
this pull request
Jul 26, 2018
Refs: #21938 (comment) and discussion below the comment. PR-URL: #21977 Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
targos
pushed a commit
that referenced
this pull request
Jul 26, 2018
Refs: #21938 (comment) and discussion below the comment. PR-URL: #21977 Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
This was referenced Aug 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Refs: #21938 (comment) and discussion below the comment.