FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: refactor v8.gyp by targos · Pull Request #22017 · nodejs/node · GitHub

/ node Public

deps: refactor v8.gyp - #22017

Closed
targos wants to merge 2 commits into
nodejs:masterfrom
targos:refactor-v8-gyp
ConversationCommits (2)ChecksFiles changed
Closed

deps: refactor v8.gyp#22017
targos wants to merge 2 commits into
nodejs:masterfrom
targos:refactor-v8-gyp

Conversation

targos commented Jul 29, 2018

Copy link
Copy Markdown
Member

Mostly reorders lists of source files to match more BUILD.gn.
Fixes a few wrong entries.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot commented Jul 29, 2018

Copy link
Copy Markdown
Collaborator

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/374/pipeline

nodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Jul 29, 2018
refack approved these changes Jul 29, 2018
View reviewed changes

refack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM 50% rubber stamp
(I skimmed the changes, but did not do a thorough compare since if it passes CI it's most probably correct)

Comment thread common.gypi Outdated

refack Jul 29, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just a question, is this required, just a formality, or does it help keep track of patches?

targos Jul 29, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Required by the V8 update guide. I would be +1 on either removing the requirement for deps/v8/gypfiles or moving the directory to another place.

refack Jul 29, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

or moving the directory to another place.

I want to do that, I just need to find the time.

targos commented Aug 1, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/16113/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/1559/

AIX rebuild: https://ci.nodejs.org/job/node-test-commit-aix/16634/

targos commented Aug 2, 2018

Copy link
Copy Markdown
Member Author

This apparently breaks the AIX build but I have no idea how.

/cc @nodejs/platform-aix

richardlau reviewed Aug 2, 2018
View reviewed changes
Comment thread deps/v8/gypfiles/v8.gyp Outdated

richardlau Aug 2, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Missing trailing comma?

targos Aug 2, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

richardlau Aug 2, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

NP. I didn't initially spot the missing comma either, but I started from the first link failure from https://ci.nodejs.org/job/node-test-commit-aix/16634/nodes=aix61-ppc64/console

10:02:02 ld: 0711-317 ERROR: Undefined symbol: .v8::base::OS::VSNPrintF(char*, int, char const*, char*)

found that v8::base::OS::VSNPrintF is defined in src/base/platform/platform-posix.cc and worked back from there. 😄

targos Aug 2, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice :). I wonder how gyp interpreted this. Was it even valid syntax?

refack Aug 2, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yeah, one of the problems of .gyp files is that this is valid python syntax (concat the two strings).
You can run the following monstrosity to get GYP to check the syntex:

python tools\gyp\gyp_main.py --check deps\v8\gypfiles\v8.gyp -I common.gypi -I config.gypi --depth=.

or for the whole project

python tools\gyp\gyp_main.py --check node.gyp -I common.gypi -I config.gypi --depth=.

targos added 2 commits August 2, 2018 23:09
deps: refactor v8.gyp
3f363ea 
Mostly reorders lists of source files to match more BUILD.gn.
Fixes a few wrong entries.
fixup aix
0f58c44

targos commented Aug 2, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/16160/

targos commented Aug 4, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

Resumed build: https://ci.nodejs.org/job/node-test-pull-request/16186/
Edit: Windows rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/19665/

targos commented Aug 4, 2018

Copy link
Copy Markdown
Member Author

Landed in 8d10557

targos closed this Aug 4, 2018
targos deleted the refactor-v8-gyp branch August 4, 2018 16:09
targos added a commit that referenced this pull request Aug 4, 2018
deps: refactor v8.gyp
8d10557 
Mostly reorders lists of source files to match more BUILD.gn.
Fixes a few wrong entries.

PR-URL: #22017
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit to psmarshall/node that referenced this pull request Aug 4, 2018
deps: refactor v8.gyp
16a807a 
Mostly reorders lists of source files to match more BUILD.gn.
Fixes a few wrong entries.

PR-URL: nodejs#22017
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

refack commented Aug 5, 2018

Copy link
Copy Markdown
Contributor

😄 I just run the command I quoted above and found:

Warning: Missing input files:
..\deps\v8\gypfiles\..\src\parsing\preparse-data-format.h

node/deps/v8/gypfiles/v8.gyp

Line 1265 in 0f58c44

'../src/parsing/preparse-data-format.h',

I'll make a mental note...

MylesBorins pushed a commit that referenced this pull request Aug 10, 2018
deps: refactor v8.gyp
ce5cacd 
Mostly reorders lists of source files to match more BUILD.gn.
Fixes a few wrong entries.

Backport-PR-URL: #21668
PR-URL: #22017
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg mentioned this pull request Aug 13, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
refack mentioned this pull request Aug 17, 2018
Closed
2 tasks
refack mentioned this pull request Aug 26, 2018
Closed
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
deps: refactor v8.gyp
981fff7 
Mostly reorders lists of source files to match more BUILD.gn.
Fixes a few wrong entries.

Backport-PR-URL: nodejs/node#21668
PR-URL: nodejs/node#22017
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

richardlau richardlau approved these changes
jasnell jasnell approved these changes
+1 more reviewer
refack refack approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL