test: fix incorrect file mode check - #22023
Closed
TimothyGu wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
@TimothyGu build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/378/pipeline |
Sorry, something went wrong.
devsnek
approved these changes
Jul 30, 2018
devsnek
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
nice catch, binop precedence always gets me
Sorry, something went wrong.
targos
approved these changes
Jul 30, 2018
JungMinu
approved these changes
Jul 30, 2018
cjihrig
approved these changes
Jul 30, 2018
jasnell
approved these changes
Jul 30, 2018
BridgeAR
approved these changes
Jul 30, 2018
Copy link
Copy Markdown
Member
|
Please +1 for fast tracking. |
Sorry, something went wrong.
lpinca
approved these changes
Jul 30, 2018
Copy link
Copy Markdown
Member
Author
|
Removing fast-tracking… forgot to run CI (oops!) |
Sorry, something went wrong.
trivikr
approved these changes
Aug 1, 2018
trivikr
pushed a commit
that referenced
this pull request
Aug 3, 2018
PR-URL: #22023 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 4, 2018
PR-URL: #22023 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Aug 16, 2018
This was referenced Aug 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mode & fs.constants.S_IROTH !== 0 is in fact equivalent to mode & (fs.constants.S_IROTH !== 0).
Checklist