FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: improve reliability in http2-session-timeout by Trott · Pull Request #22026 · nodejs/node · GitHub

/ node Public

test: improve reliability in http2-session-timeout - #22026

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:further-reliability
ConversationCommits (1)ChecksFiles changed
Closed

test: improve reliability in http2-session-timeout#22026
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:further-reliability

Conversation

Trott commented Jul 30, 2018

Copy link
Copy Markdown
Member

Use setImmediate() instead of setTimeout() to improve robustness of
test-http2-session-timeout.

Fixes: #20628

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot commented Jul 30, 2018

Copy link
Copy Markdown
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/379/pipeline

nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 30, 2018
Trott force-pushed the further-reliability branch from 170374d to d328194 Compare July 30, 2018 02:29
test: improve reliability in http2-session-timeout
3ee47c7 
Use `setImmediate()` instead of `setTimeout()` to improve robustness of
test-http2-session-timeout.

Fixes: nodejs#20628
Trott force-pushed the further-reliability branch from d328194 to 3ee47c7 Compare July 30, 2018 02:29
apapirovski reviewed Jul 30, 2018
View reviewed changes
Comment thread test/sequential/test-http2-session-timeout.js
const milliseconds = (diff[0] * 1e3 + diff[1] / 1e6);
if (milliseconds < serverTimeout * 2) {
setTimeout(makeReq, callTimeout);
setImmediate(makeReq);

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

Trott commented Jul 30, 2018

Copy link
Copy Markdown
Member Author

Lite CI: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/380/pipeline

apapirovski suggested changes Jul 30, 2018
View reviewed changes

apapirovski left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

All I can suggest is making the server timeout 1000 and the callTimeout 200. The current change makes this test no longer valid.

apapirovski approved these changes Jul 31, 2018
View reviewed changes

apapirovski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

D'oh, I totally misread how this test works. Works for me if this actually fixes the flakiness

apapirovski commented Jul 31, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

@Trott can we confirm with a stress test? From what I recall of writing this test, launching too many requests was problematic in making the test flaky in a different way. I used to have setTimeout for 1ms which was nearly equivalent to this.

Edit: just got home and started it myself https://ci.nodejs.org/job/node-stress-single-test/1973/

Trott commented Jul 31, 2018

Copy link
Copy Markdown
Member Author

@nodejs/testing

apapirovski commented Aug 1, 2018

Copy link
Copy Markdown
Contributor

I ran two stress tests and both appear to be green. 🎉

Trott commented Aug 1, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/16108/

Trott commented Aug 1, 2018

Copy link
Copy Markdown
Member Author

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16112/

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 1, 2018

Trott commented Aug 1, 2018

Copy link
Copy Markdown
Member Author

Resume build: https://ci.nodejs.org/job/node-test-pull-request/16135/

Trott added a commit to Trott/io.js that referenced this pull request Aug 1, 2018
test: improve reliability in http2-session-timeout
d2ffcac 
Use `setImmediate()` instead of `setTimeout()` to improve robustness of
test-http2-session-timeout.

Fixes: nodejs#20628

PR-URL: nodejs#22026
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Trott commented Aug 1, 2018

Copy link
Copy Markdown
Member Author

Landed in d2ffcac

Trott closed this Aug 1, 2018
targos pushed a commit that referenced this pull request Aug 2, 2018
test: improve reliability in http2-session-timeout
a40ee21 
Use `setImmediate()` instead of `setTimeout()` to improve robustness of
test-http2-session-timeout.

Fixes: #20628

PR-URL: #22026
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
rvagg mentioned this pull request Aug 13, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
kjin pushed a commit to kjin/node that referenced this pull request Sep 25, 2018
test: improve reliability in http2-session-timeout
70d7a4c 
Use `setImmediate()` instead of `setTimeout()` to improve robustness of
test-http2-session-timeout.

Fixes: nodejs#20628

PR-URL: nodejs#22026
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kjin pushed a commit to kjin/node that referenced this pull request Oct 16, 2018
test: improve reliability in http2-session-timeout
23b53e7 
Use `setImmediate()` instead of `setTimeout()` to improve robustness of
test-http2-session-timeout.

Fixes: nodejs#20628

PR-URL: nodejs#22026
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
test: improve reliability in http2-session-timeout
7ea08ee 
Use `setImmediate()` instead of `setTimeout()` to improve robustness of
test-http2-session-timeout.

Fixes: #20628

Backport-PR-URL: #22850
PR-URL: #22026
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs mentioned this pull request Oct 30, 2018
Merged
beevelop mentioned this pull request Nov 20, 2018
Closed
Trott deleted the further-reliability branch January 13, 2022 22:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
trivikr trivikr approved these changes
+3 more reviewers
apapirovski apapirovski approved these changes
sagirk sagirk approved these changes
maclover7 maclover7 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate flaky test-http2-session-timeout

7 participants

Back | FazBrowse Home | New Git URL