[10.x] deps: V8: backport 4 CPU profiler commits from upstream - #22028
Closed
psmarshall wants to merge 1 commit into
Closed
[10.x] deps: V8: backport 4 CPU profiler commits from upstream#22028psmarshall wants to merge 1 commit into
psmarshall wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I'd like to land this with the V8 update (to 6.8) on 10.x |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
/cc @nodejs/v8-update EDIT: |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
v8_embedder_string in common.gypi should be bumped (by 1). |
Sorry, something went wrong.
psmarshall
force-pushed
the
backport-cpu-profiler-to-v10.x
branch
from
c5be937 to
406d2f6
Compare
August 3, 2018 11:21
Copy link
Copy Markdown
Contributor
Author
|
Thanks, I've bumped v8_embedder_string |
Sorry, something went wrong.
psmarshall
force-pushed
the
backport-cpu-profiler-to-v10.x
branch
from
406d2f6 to
4445b31
Compare
August 16, 2018 09:35
Copy link
Copy Markdown
Contributor
Author
|
@ofrobots I've rebased now that V8 6.8 has landed on v10.x-staging, so we should be OK to land this so that it can be in the 10.10 release |
Sorry, something went wrong.
BridgeAR
approved these changes
Aug 16, 2018
BridgeAR
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
RSLGTM
Sorry, something went wrong.
2 tasks
psmarshall
force-pushed
the
backport-cpu-profiler-to-v10.x
branch
from
4445b31 to
fe2ada8
Compare
August 29, 2018 09:04
bmeurer
approved these changes
Aug 29, 2018
bmeurer
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM (rubber-stamped)
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Any reason not to land this on the master branch? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@targos I don't see why not. I'll retarget it to master |
Sorry, something went wrong.
[cpu-profiler] Add a new profiling mode with a more detailed call tree. https://chromium.googlesource.com/v8/v8.git/+/ecae80cdb350dde1e654c531b56f5b6c44dc8c77 [cpu-profiler] Reuse free slots in code_entries_ https://chromium.googlesource.com/v8/v8.git/+/3e1126bf15e62c433c4e9cb21316d182f691c63a [cpu-profiler] Only store deopt inline frames for functions that need it https://chromium.googlesource.com/v8/v8.git/+/0bfcbdd4726920755e51dab28c18ab93e050819b [cpu-profiler] Use instruction start as the key for the CodeMap https://chromium.googlesource.com/v8/v8.git/+/ba752ea4c50713dff1e94f45a79db3ba968a8d66
psmarshall
force-pushed
the
backport-cpu-profiler-to-v10.x
branch
from
fe2ada8 to
95072d7
Compare
August 29, 2018 14:15
Copy link
Copy Markdown
Member
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
[cpu-profiler] Add a new profiling mode with a more detailed call tree. https://chromium.googlesource.com/v8/v8.git/+/ecae80cdb350dde1e654c531b56f5b6c44dc8c77 [cpu-profiler] Reuse free slots in code_entries_ https://chromium.googlesource.com/v8/v8.git/+/3e1126bf15e62c433c4e9cb21316d182f691c63a [cpu-profiler] Only store deopt inline frames for functions that need it https://chromium.googlesource.com/v8/v8.git/+/0bfcbdd4726920755e51dab28c18ab93e050819b [cpu-profiler] Use instruction start as the key for the CodeMap https://chromium.googlesource.com/v8/v8.git/+/ba752ea4c50713dff1e94f45a79db3ba968a8d66 PR-URL: #22028 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>
Copy link
Copy Markdown
Member
|
It turns out this change breaks V8 tests: 14:15:07 ../../test/cctest/test-log.cc:741:59: error: non-virtual member function marked 'override' hides virtual member function
14:15:07 void CodeMoveEvent(i::AbstractCode* from, Address to) override {}
14:15:07 ^
14:15:07 ../../src/code-events.h:86:16: note: hidden overloaded virtual function 'v8::internal::CodeEventListener::CodeMoveEvent' declared here: type mismatch at 2nd parameter ('v8::internal::AbstractCode *' vs 'v8::internal::Address' (aka 'unsigned long'))
14:15:07 virtual void CodeMoveEvent(AbstractCode* from, AbstractCode* to) = 0;
14:15:07 ^
14:15:07 ../../test/cctest/test-log.cc:750:5: error: variable type 'class (anonymous class at ../../test/cctest/test-log.cc:739:3)' is an abstract class
14:15:07 } code_event_logger;
14:15:07 ^
14:15:07 ../../src/code-events.h:86:16: note: unimplemented pure virtual method 'CodeMoveEvent' in ''
14:15:07 virtual void CodeMoveEvent(AbstractCode* from, AbstractCode* to) = 0;
14:15:07 ^
14:15:07 2 errors generated.
Edit: fix at #22677 |
Sorry, something went wrong.
targos
added a commit
to targos/node
that referenced
this pull request
Sep 3, 2018
Fixes a regression introduced in a V8 backport PR. A small change in cctest/test-log.cc was forgotten. Refs: nodejs#22028 Refs: v8/v8@ba752ea
addaleax
pushed a commit
that referenced
this pull request
Sep 3, 2018
[cpu-profiler] Add a new profiling mode with a more detailed call tree. https://chromium.googlesource.com/v8/v8.git/+/ecae80cdb350dde1e654c531b56f5b6c44dc8c77 [cpu-profiler] Reuse free slots in code_entries_ https://chromium.googlesource.com/v8/v8.git/+/3e1126bf15e62c433c4e9cb21316d182f691c63a [cpu-profiler] Only store deopt inline frames for functions that need it https://chromium.googlesource.com/v8/v8.git/+/0bfcbdd4726920755e51dab28c18ab93e050819b [cpu-profiler] Use instruction start as the key for the CodeMap https://chromium.googlesource.com/v8/v8.git/+/ba752ea4c50713dff1e94f45a79db3ba968a8d66 PR-URL: #22028 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>
targos
added a commit
to targos/node
that referenced
this pull request
Sep 4, 2018
Fixes a regression introduced in a V8 backport PR. A small change in cctest/test-log.cc was forgotten. Refs: nodejs#22028 Refs: v8/v8@ba752ea PR-URL: nodejs#22677 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Copy link
Copy Markdown
Contributor
Author
|
Thanks for fixing that. I think I somehow missed the changes to test-log.cc when I was fixing conflicts - the fix to the test should have been included in this one: [cpu-profiler] Use instruction start as the key for the CodeMap |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Sep 5, 2018
[cpu-profiler] Add a new profiling mode with a more detailed call tree. https://chromium.googlesource.com/v8/v8.git/+/ecae80cdb350dde1e654c531b56f5b6c44dc8c77 [cpu-profiler] Reuse free slots in code_entries_ https://chromium.googlesource.com/v8/v8.git/+/3e1126bf15e62c433c4e9cb21316d182f691c63a [cpu-profiler] Only store deopt inline frames for functions that need it https://chromium.googlesource.com/v8/v8.git/+/0bfcbdd4726920755e51dab28c18ab93e050819b [cpu-profiler] Use instruction start as the key for the CodeMap https://chromium.googlesource.com/v8/v8.git/+/ba752ea4c50713dff1e94f45a79db3ba968a8d66 PR-URL: #22028 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>
targos
added a commit
that referenced
this pull request
Sep 5, 2018
Fixes a regression introduced in a V8 backport PR. A small change in cctest/test-log.cc was forgotten. Refs: #22028 Refs: v8/v8@ba752ea PR-URL: #22677 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
[cpu-profiler] Add a new profiling mode with a more detailed call tree. https://chromium.googlesource.com/v8/v8.git/+/ecae80cdb350dde1e654c531b56f5b6c44dc8c77 [cpu-profiler] Reuse free slots in code_entries_ https://chromium.googlesource.com/v8/v8.git/+/3e1126bf15e62c433c4e9cb21316d182f691c63a [cpu-profiler] Only store deopt inline frames for functions that need it https://chromium.googlesource.com/v8/v8.git/+/0bfcbdd4726920755e51dab28c18ab93e050819b [cpu-profiler] Use instruction start as the key for the CodeMap https://chromium.googlesource.com/v8/v8.git/+/ba752ea4c50713dff1e94f45a79db3ba968a8d66 PR-URL: #22028 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>
targos
added a commit
that referenced
this pull request
Sep 6, 2018
Fixes a regression introduced in a V8 backport PR. A small change in cctest/test-log.cc was forgotten. Refs: #22028 Refs: v8/v8@ba752ea PR-URL: #22677 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
@ofrobots
[cpu-profiler] Add a new profiling mode with a more detailed call tree.
https://chromium.googlesource.com/v8/v8.git/+/ecae80cdb350dde1e654c531b56f5b6c44dc8c77
[cpu-profiler] Reuse free slots in code_entries_
https://chromium.googlesource.com/v8/v8.git/+/3e1126bf15e62c433c4e9cb21316d182f691c63a
[cpu-profiler] Only store deopt inline frames for functions that need it
https://chromium.googlesource.com/v8/v8.git/+/0bfcbdd4726920755e51dab28c18ab93e050819b
[cpu-profiler] Use instruction start as the key for the CodeMap
https://chromium.googlesource.com/v8/v8.git/+/ba752ea4c50713dff1e94f45a79db3ba968a8d66