FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update BUILDING.md by brandonlwt · Pull Request #22067 · nodejs/node · GitHub

/ node Public

Update BUILDING.md - #22067

Closed
brandonlwt wants to merge 1 commit into
nodejs:masterfrom
brandonlwt:master
ConversationCommits (1)ChecksFiles changed
Closed

Update BUILDING.md#22067
brandonlwt wants to merge 1 commit into
nodejs:masterfrom
brandonlwt:master

Conversation

brandonlwt commented Aug 1, 2018

Copy link
Copy Markdown
Contributor

Grammatical error corrected.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • [x ] documentation is changed or added
  • commit message follows commit guidelines

Update BUILDING.md
ca6190c 
Grammatical error corrected.
nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Aug 1, 2018

addaleax commented Aug 1, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/395/pipeline

Collaborators, please feel free to 👍 this comment to approve fast-tracking.

addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 1, 2018
vsemozhetbyt approved these changes Aug 1, 2018
View reviewed changes

vsemozhetbyt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you.

brandonlwt commented Aug 1, 2018

Copy link
Copy Markdown
Contributor Author

Good day, may I know when will it be merged?
Your kind consideration is highly appreciated.
Thank you.

addaleax commented Aug 1, 2018

Copy link
Copy Markdown
Member

@brandonlwt Fast-tracking means that it can be merged as soon as all automated checks are green.

… Which they are now, so:

Landed in 05b3176 🎉 Congratulations and thanks for the pull request!

addaleax closed this Aug 1, 2018
addaleax pushed a commit that referenced this pull request Aug 1, 2018
doc: correct grammatical error in BUILDING.md
05b3176 
Grammatical error corrected.

PR-URL: #22067
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>

brandonlwt commented Aug 1, 2018

Copy link
Copy Markdown
Contributor Author

Oh! Thank you for the explanation! Highly appreciated!
vielen Dank!

targos pushed a commit that referenced this pull request Aug 1, 2018
doc: correct grammatical error in BUILDING.md
c6a56ae 
Grammatical error corrected.

PR-URL: #22067
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
rvagg mentioned this pull request Aug 13, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
+1 more reviewer
vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL