FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

benchmark: allow to add lines to scatter plots by lundibundi · Pull Request #22074 · nodejs/node · GitHub

/ node Public

benchmark: allow to add lines to scatter plots - #22074

Closed
lundibundi wants to merge 2 commits into
nodejs:masterfrom
lundibundi:add-lines-scatter
ConversationCommits (2)ChecksFiles changed
Closed

benchmark: allow to add lines to scatter plots#22074
lundibundi wants to merge 2 commits into
nodejs:masterfrom
lundibundi:add-lines-scatter

Conversation

lundibundi commented Aug 1, 2018

Copy link
Copy Markdown
Member

Adds --add-lines option to scatter.R that will add lines between the points of the same category.

It was helpful for me to see a general trend with different options, so I added this.
Also, this is my first time working with R so please be thorough, maybe I've missed something.

Checklist
  • make -j4 test (UNIX) passes
  • documentation is changed or added (I'll change benchmark guide later it this is an acceptable change)
  • commit message follows [commit guidelines]


/cc @nodejs/benchmarking

nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Aug 1, 2018
BridgeAR requested a review from AndreasMadsen August 1, 2018 23:49
AndreasMadsen approved these changes Aug 2, 2018
View reviewed changes

AndreasMadsen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, although I don't see why it needs to be an option.

lundibundi commented Aug 2, 2018

Copy link
Copy Markdown
Member Author

Making it non-optional is okay with me too, as it's hard to understand the plot based on dots-colors alone. I just didn't want to disrupt those who already use it too much.
Should we +1 on this to make a simple vote for non-optional(+1) vs optional(-1)?

I'll add/change the doc example once this is decided then.

AndreasMadsen commented Aug 3, 2018

Copy link
Copy Markdown
Member

@lundibundi I wouldn't bother. Very few people know about this tool, even less uses it. In fact, before you, I'm was the only contributor to it.

TimothyGu reviewed Aug 3, 2018
View reviewed changes

TimothyGu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

+1 for just make it always on.

lundibundi commented Aug 5, 2018

Copy link
Copy Markdown
Member Author

Now that I think of it, how should I update the plot in benchmarks guide, will it be okay to just put node master string_decode benchmarks there? (Also, maybe csv used in there is available somewhere?).
Or maybe it's fine to let it be like this (without lines)?

TimothyGu commented Aug 5, 2018

Copy link
Copy Markdown
Member

how should I update the plot in benchmarks guide, will it be okay to just put node master string_decode benchmarks there

Yeah, if you could just rerun the benchmark that generated that plot and update the graph that'd be great. I don't think the CSV used for the existing graph is available anywhere as the data can be regenerated quickly.

lundibundi commented Aug 5, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

Ok, I've updated the doc. PTAL.
Also, should I add the csv in order to simplify future edits?

TimothyGu commented Aug 7, 2018

Copy link
Copy Markdown
Member

@lundibundi Nah, these files don't get touched often. Plus we can always regenerate.

TimothyGu added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 7, 2018

jasnell commented Aug 12, 2018

Copy link
Copy Markdown
Member

CI failed entirely, running again: https://ci.nodejs.org/job/node-test-pull-request/16385/

joyeecheung mentioned this pull request Aug 15, 2018
Closed

lundibundi commented Aug 24, 2018

Copy link
Copy Markdown
Member Author

New CI: https://ci.nodejs.org/job/node-test-pull-request/16720/

jasnell commented Aug 24, 2018

Copy link
Copy Markdown
Member

@lundibundi ... can you rebase this off of current master. There are some changes that need to be pulled in before this will pass CI

lundibundi commented Aug 25, 2018

Copy link
Copy Markdown
Member Author

@jasnell oh, forgot about that, thanks.
New CI: https://ci.nodejs.org/job/node-test-pull-request/16752/

benchmark: add lines to scatter plots
c65b302 
Adds lines between the points of the same category in scatter.R plots.
fixup! doc: update benchmark guide
b15fb2d

lundibundi commented Aug 27, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

One more: https://ci.nodejs.org/job/node-test-pull-request/16772/
(Rebased just in case)

Known flaky async-hooks/test-callback-error (#15985) failed.
Resume: https://ci.nodejs.org/job/node-test-pull-request/16779/

addaleax commented Sep 2, 2018

Copy link
Copy Markdown
Member

Landed in 7aac706

addaleax closed this Sep 2, 2018
addaleax pushed a commit that referenced this pull request Sep 2, 2018
benchmark: add lines to scatter plots
7aac706 
Adds lines between the points of the same category in scatter.R plots.

PR-URL: #22074
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
targos pushed a commit that referenced this pull request Sep 2, 2018
benchmark: add lines to scatter plots
3500905 
Adds lines between the points of the same category in scatter.R plots.

PR-URL: #22074
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
lundibundi deleted the add-lines-scatter branch September 3, 2018 10:59
targos pushed a commit that referenced this pull request Sep 3, 2018
benchmark: add lines to scatter plots
48648f5 
Adds lines between the points of the same category in scatter.R plots.

PR-URL: #22074
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
benchmark: add lines to scatter plots
dfde87a 
Adds lines between the points of the same category in scatter.R plots.

PR-URL: #22074
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
This was referenced Sep 6, 2018
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
+3 more reviewers
apapirovski apapirovski approved these changes
AndreasMadsen AndreasMadsen approved these changes
TimothyGu TimothyGu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. benchmark Issues and PRs related to the benchmark subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL