src: yield empty maybes for failed AsyncWrap::MakeCallback calls - #22078
Closed
addaleax wants to merge 1 commit into
Closed
src: yield empty maybes for failed AsyncWrap::MakeCallback calls#22078addaleax wants to merge 1 commit into
addaleax wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Use an empty `MaybeLocal<Value>` as the return value for `AsyncWrap::MakeCallback()` if an exception occurred, regardless of `MakeCallback` depth. Unfortunately, the public API can not make this switch without a breaking change (and possibly some kind of deprecation/renaming).
Copy link
Copy Markdown
Collaborator
|
@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/400/pipeline |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
joyeecheung
approved these changes
Aug 2, 2018
ryzokuken
approved these changes
Aug 2, 2018
jasnell
approved these changes
Aug 3, 2018
Copy link
Copy Markdown
Member
Author
|
CI: https://ci.nodejs.org/job/node-test-pull-request/16290/ Edit: Resume: https://ci.nodejs.org/job/node-test-pull-request/16339/ |
Sorry, something went wrong.
maclover7
approved these changes
Aug 11, 2018
Copy link
Copy Markdown
Member
|
Re-run custom suites CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/59/ |
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
Aug 12, 2018
Use an empty `MaybeLocal<Value>` as the return value for `AsyncWrap::MakeCallback()` if an exception occurred, regardless of `MakeCallback` depth. Unfortunately, the public API can not make this switch without a breaking change (and possibly some kind of deprecation/renaming). PR-URL: #22078 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
Copy link
Copy Markdown
Member
|
@addaleax would you mind backporting this to v10.x-staging please? There's a change in master that removed an additional IsInnerMakeCallback() that's not in v10.x and I'm not confident enough in what should be done about it so I'll leave it to you. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I think this applies cleanly now? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@addaleax it applies cleanly but fails to compile. |
Sorry, something went wrong.
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Aug 24, 2018
Use an empty `MaybeLocal<Value>` as the return value for `AsyncWrap::MakeCallback()` if an exception occurred, regardless of `MakeCallback` depth. Unfortunately, the public API can not make this switch without a breaking change (and possibly some kind of deprecation/renaming). PR-URL: nodejs#22078 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
addaleax
added a commit
that referenced
this pull request
Aug 28, 2018
Use an empty `MaybeLocal<Value>` as the return value for `AsyncWrap::MakeCallback()` if an exception occurred, regardless of `MakeCallback` depth. Unfortunately, the public API can not make this switch without a breaking change (and possibly some kind of deprecation/renaming). PR-URL: #22078 Backport-PR-URL: #22505 Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
Use an empty `MaybeLocal<Value>` as the return value for `AsyncWrap::MakeCallback()` if an exception occurred, regardless of `MakeCallback` depth. Unfortunately, the public API can not make this switch without a breaking change (and possibly some kind of deprecation/renaming). PR-URL: #22078 Backport-PR-URL: #22505 Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
Use an empty `MaybeLocal<Value>` as the return value for `AsyncWrap::MakeCallback()` if an exception occurred, regardless of `MakeCallback` depth. Unfortunately, the public API can not make this switch without a breaking change (and possibly some kind of deprecation/renaming). PR-URL: #22078 Backport-PR-URL: #22505 Reviewed-By: Michaël Zasso <targos@protonmail.com>
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use an empty MaybeLocal<Value> as the return value for
AsyncWrap::MakeCallback() if an exception occurred,
regardless of MakeCallback depth.
Unfortunately, the public API can not make this switch without
a breaking change (and possibly some kind of deprecation/renaming).
Checklist