FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: cherry-pick 6ee8345 from upstream V8 by joyeecheung · Pull Request #22106 · nodejs/node · GitHub

/ node Public

deps: cherry-pick 6ee8345 from upstream V8 - #22106

Closed
joyeecheung wants to merge 2 commits into
nodejs:masterfrom
joyeecheung:backport-edge-name
ConversationCommits (2)ChecksFiles changed
Closed

deps: cherry-pick 6ee8345 from upstream V8#22106
joyeecheung wants to merge 2 commits into
nodejs:masterfrom
joyeecheung:backport-edge-name

Conversation

joyeecheung commented Aug 3, 2018

Copy link
Copy Markdown
Member

Original commit message:

[heap-profiler] Allow embedder to specify edge names

This patch adds a variant of EmbedderGraph::AddEdge() which
allows the embedder to specify the name of an edge. The edges
added without name are element edges with auto-incremented indexes
while the edges added with names will be internal edges with
the specified names for more meaningful output in the heap
snapshot.

Refs: https://github.com/nodejs/node/pull/21741
Bug: v8:7938
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I8feefa2cf6911743e24b3b2024e0e849b0c65cd3
Reviewed-on: https://chromium-review.googlesource.com/1133299
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54412}

Refs: v8/v8@6ee8345

cc @addaleax

nodejs-github-bot commented Aug 3, 2018

Copy link
Copy Markdown
Collaborator

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/413/pipeline

nodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Aug 3, 2018

joyeecheung commented Aug 3, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/16168/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1567/

targos commented Aug 3, 2018

Copy link
Copy Markdown
Member

Why don't land on v10?

joyeecheung commented Aug 3, 2018

Copy link
Copy Markdown
Member Author

@targos Because this is ABI-breaking.

This patch needs additional tweaking in src/heap_utils.cc to compile, I'm working on a fix

joyeecheung commented Aug 3, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/16175/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1569/

joyeecheung commented Aug 3, 2018

Copy link
Copy Markdown
Member Author

CI is green. Can you take a look at the new commit? Thanks! @addaleax

addaleax approved these changes Aug 3, 2018
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice, thanks!

joyeecheung commented Aug 4, 2018

Copy link
Copy Markdown
Member Author

Uh, wait, I was working on naming edges on top of this PR and noticed that there was a bug in test/common/heap.js so the graph has not been actually validated (if (expectedNode.edges) should've been if (expectedNode.children)), which hide another bug in this PR (edge_info had not been pushed to the edges array - the entries were still the edge targets)

I've fixed the bugs, PTAL, thanks! @addaleax @jasnell

CI: https://ci.nodejs.org/job/node-test-pull-request/16185/

joyeecheung commented Aug 7, 2018

Copy link
Copy Markdown
Member Author

Ping @addaleax @jasnell Can you take a look at the last commit? Thanks!

joyeecheung commented Aug 9, 2018

Copy link
Copy Markdown
Member Author

Ping again: @addaleax @jasnell

joyeecheung commented Aug 9, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/16305/

joyeecheung commented Aug 10, 2018

Copy link
Copy Markdown
Member Author

New CI: https://ci.nodejs.org/job/node-test-pull-request/16330/

joyeecheung commented Aug 11, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/16369/

joyeecheung commented Aug 13, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/16422/

joyeecheung mentioned this pull request Aug 15, 2018
Closed
deps: cherry-pick 6ee8345 from upstream V8
2949154 
Original commit message:

    [heap-profiler] Allow embedder to specify edge names

    This patch adds a variant of EmbedderGraph::AddEdge() which
    allows the embedder to specify the name of an edge. The edges
    added without name are element edges with auto-incremented indexes
    while the edges added with names will be internal edges with
    the specified names for more meaningful output in the heap
    snapshot.

    Refs: nodejs#21741
    Bug: v8:7938
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
    Change-Id: I8feefa2cf6911743e24b3b2024e0e849b0c65cd3
    Reviewed-on: https://chromium-review.googlesource.com/1133299
    Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{nodejs#54412}

Refs: v8/v8@6ee8345
src: implement the new EmbedderGraph::AddEdge()
de527a9 
The signature of EmbedderGraph::AddEdge() has been changed so
the current implementation of JSGraph no longer compiles.
This patch updates the implementation accordingly.

joyeecheung commented Aug 17, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/16517/

joyeecheung commented Aug 17, 2018

Copy link
Copy Markdown
Member Author

One unrelated failure. Resume build: https://ci.nodejs.org/job/node-test-pull-request/16522/

Failures in job https://ci.nodejs.org/job/node-test-pull-request/16517/

rhel72-s390x

See failures on test-linuxonecc-rhel72-s390x-3: 
not ok 1957 parallel/test-trace-events-fs-sync
  ---
  duration_ms: 2.641
  severity: fail
  exitcode: 1
  stack: |-
    assert.js:84
      throw new AssertionError(obj);
      ^
    
    AssertionError [ERR_ASSERTION]: fs.sync.open:
    { status: null,
      signal: 'SIGSEGV',
      output: [ null, '', '' ],
      pid: 29496,
      stdout: '',
      stderr: '' }
        at Object.<anonymous> (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/parallel/test-trace-events-fs-sync.js:139:10)
        at Module._compile (internal/modules/cjs/loader.js:689:30)
        at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
        at Module.load (internal/modules/cjs/loader.js:599:32)
        at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
        at Function.Module._load (internal/modules/cjs/loader.js:530:3)
        at Function.Module.runMain (internal/modules/cjs/loader.js:742:12)
        at startup (internal/bootstrap/node.js:257:19)
        at bootstrapNodeJSCore (internal/bootstrap/node.js:628:3)
  ...

joyeecheung commented Aug 17, 2018

Copy link
Copy Markdown
Member Author

CI is green

joyeecheung commented Aug 18, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

Landed in 44d04a8...2d72a95

joyeecheung added a commit that referenced this pull request Aug 18, 2018
deps: cherry-pick 6ee8345 from upstream V8
54c87f3 
Original commit message:

    [heap-profiler] Allow embedder to specify edge names

    This patch adds a variant of EmbedderGraph::AddEdge() which
    allows the embedder to specify the name of an edge. The edges
    added without name are element edges with auto-incremented indexes
    while the edges added with names will be internal edges with
    the specified names for more meaningful output in the heap
    snapshot.

    Refs: #21741
    Bug: v8:7938
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
    Change-Id: I8feefa2cf6911743e24b3b2024e0e849b0c65cd3
    Reviewed-on: https://chromium-review.googlesource.com/1133299
    Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54412}

Refs: v8/v8@6ee8345

PR-URL: #22106
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung added a commit that referenced this pull request Aug 18, 2018
src: implement the new EmbedderGraph::AddEdge()
2d72a95 
The signature of EmbedderGraph::AddEdge() has been changed so
the current implementation of JSGraph no longer compiles.
This patch updates the implementation accordingly.

PR-URL: #22106
Refs: v8/v8@6ee8345
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung mentioned this pull request Aug 20, 2018
Closed
targos added a commit to targos/node that referenced this pull request Aug 28, 2018
deps: sync V8 embedder string with master branch
514e700 
To avoid conflicts while cherry-picking future V8 backports, increment
the embedder string by one so it has the same value as in the master
branch. The value was off by one because of an ABI-breaking backport
that could not be taken in v10.x.

Refs: nodejs#22106
targos mentioned this pull request Aug 28, 2018
Closed
targos added a commit that referenced this pull request Aug 30, 2018
deps: sync V8 embedder string with master branch
ea72368 
To avoid conflicts while cherry-picking future V8 backports, increment
the embedder string by one so it has the same value as in the master
branch. The value was off by one because of an ABI-breaking backport
that could not be taken in v10.x.

Refs: #22106

PR-URL: #22573
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos added a commit that referenced this pull request Sep 3, 2018
deps: sync V8 embedder string with master branch
1be23f7 
To avoid conflicts while cherry-picking future V8 backports, increment
the embedder string by one so it has the same value as in the master
branch. The value was off by one because of an ABI-breaking backport
that could not be taken in v10.x.

Refs: #22106

PR-URL: #22573
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos added a commit that referenced this pull request Sep 6, 2018
deps: sync V8 embedder string with master branch
efeba2f 
To avoid conflicts while cherry-picking future V8 backports, increment
the embedder string by one so it has the same value as in the master
branch. The value was off by one because of an ABI-breaking backport
that could not be taken in v10.x.

Refs: #22106

PR-URL: #22573
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
joyeecheung mentioned this pull request Oct 4, 2018
Closed
4 tasks
joyeecheung added a commit to joyeecheung/node that referenced this pull request Oct 5, 2018
src: implement the new EmbedderGraph::AddEdge()
e2d8f7a 
The signature of EmbedderGraph::AddEdge() has been changed so
the current implementation of JSGraph no longer compiles.
This patch updates the implementation accordingly.

PR-URL: nodejs#22106
Refs: v8/v8@6ee8345
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung mentioned this pull request Oct 6, 2018
Closed
targos pushed a commit that referenced this pull request Oct 7, 2018
src: implement the new EmbedderGraph::AddEdge()
1712458 
The signature of EmbedderGraph::AddEdge() has been changed so
the current implementation of JSGraph no longer compiles.
This patch updates the implementation accordingly.

Backport-PR-URL: #23295
PR-URL: #22106
Refs: v8/v8@6ee8345
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 7, 2018
src: implement the new EmbedderGraph::AddEdge()
390fc85 
The signature of EmbedderGraph::AddEdge() has been changed so
the current implementation of JSGraph no longer compiles.
This patch updates the implementation accordingly.

Backport-PR-URL: #23295
PR-URL: #22106
Refs: v8/v8@6ee8345
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
snyk-bot mentioned this pull request Apr 1, 2020
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL