doc: add rubys to collaborators - #22109
Closed
rubys wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
@rubys build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/415/pipeline |
Sorry, something went wrong.
Trott
reviewed
Aug 3, 2018
Comment thread
README.md
Outdated
| **Ron Korving** <ron@ronkorving.nl> | ||
| * [RReverser](https://github.com/RReverser) - | ||
| **Sam Ruby** <rubys@intertwingly.net> | ||
| * [rubys](https://github.com/rubys) - |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
The lines above are reversed.
Sorry, something went wrong.
Trott
approved these changes
Aug 3, 2018
vsemozhetbyt
approved these changes
Aug 3, 2018
Copy link
Copy Markdown
Contributor
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
Sorry, something went wrong.
gireeshpunathil
approved these changes
Aug 3, 2018
richardlau
approved these changes
Aug 3, 2018
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
cjihrig
approved these changes
Aug 3, 2018
bengl
approved these changes
Aug 3, 2018
TimothyGu
approved these changes
Aug 3, 2018
rubys
added a commit
that referenced
this pull request
Aug 3, 2018
PR-URL: #22109 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
targos
pushed a commit
that referenced
this pull request
Aug 4, 2018
PR-URL: #22109 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com>
This was referenced Aug 16, 2018
This was referenced Aug 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist