FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: update ESLint to 5.3.0 by Trott · Pull Request #22134 · nodejs/node · GitHub

/ node Public

tools: update ESLint to 5.3.0 - #22134

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:eslint-5.3.0
ConversationCommits (1)ChecksFiles changed
Closed

tools: update ESLint to 5.3.0#22134
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:eslint-5.3.0

Conversation

Trott commented Aug 5, 2018

Copy link
Copy Markdown
Member

Since we made some efforts to make the ESLint updates in Node.js core a little bit less churn-y, maybe we can do more frequent smaller updates like this? (Or maybe it's still too churn-y?)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot commented Aug 5, 2018

Copy link
Copy Markdown
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/431/pipeline

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Aug 5, 2018

Trott commented Aug 5, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

Since the lite CI runs the linter and none of the other jobs in node-test-pull-request touch this code, the lite CI is probably sufficient here.

Trott commented Aug 5, 2018

Copy link
Copy Markdown
Member Author

Test failure is a known flaky (#21038).

Re-running: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/432/pipeline

Trott commented Aug 5, 2018

Copy link
Copy Markdown
Member Author

@nodejs/linting

BridgeAR approved these changes Aug 5, 2018
View reviewed changes

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

maclover7 approved these changes Aug 5, 2018
View reviewed changes

maclover7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM if CI is green

trivikr approved these changes Aug 5, 2018
View reviewed changes

trivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RSLGTM

Trott commented Aug 8, 2018

Copy link
Copy Markdown
Member Author

Landed in 6ad12d4

Trott added a commit to Trott/io.js that referenced this pull request Aug 8, 2018
tools: update ESLint to 5.3.0
6ad12d4 
PR-URL: nodejs#22134
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Trott closed this Aug 8, 2018
targos pushed a commit that referenced this pull request Aug 11, 2018
tools: update ESLint to 5.3.0
e152cf7 
PR-URL: #22134
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
vsemozhetbyt mentioned this pull request Aug 12, 2018
Closed
2 tasks
rvagg mentioned this pull request Aug 13, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Trott deleted the eslint-5.3.0 branch January 13, 2022 22:50
aliceUnhinged613 mentioned this pull request May 16, 2022
Open
This was referenced May 16, 2022
Open
Open
kissofire mentioned this pull request May 16, 2022
Open
wedataintelligence mentioned this pull request May 16, 2022
Open
ron-a20 mentioned this pull request May 16, 2022
Open
molllyn1 mentioned this pull request May 17, 2022
Open
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
tools: update ESLint to 5.3.0
950a4a9 
PR-URL: nodejs/node#22134
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bengl bengl approved these changes
BridgeAR BridgeAR approved these changes
trivikr trivikr approved these changes
+2 more reviewers
silverwind silverwind approved these changes
maclover7 maclover7 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL