test: remove common.fileExists() - #22151
Conversation
Sorry, something went wrong.
common.fileExists() can be replaced with fs.existsSync().
|
@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/442/pipeline |
Sorry, something went wrong.
Sorry, something went wrong.
fesebuv
left a comment
There was a problem hiding this comment.
Seems good to me, but I would advice to double check why some tests are failing.
Sorry, something went wrong.
|
https://ci.nodejs.org/job/node-test-commit-custom-suites/458/default/console failed because of stale processes. Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16225/ |
Sorry, something went wrong.
ChALkeR
left a comment
There was a problem hiding this comment.
LGTM if tests pass.
Sorry, something went wrong.
|
git grep fileExists shows it's still used in test/common/index.mjs. Line 36 in a4c1cf5 |
Sorry, something went wrong.
|
CI with @targos's comment addressed: https://ci.nodejs.org/job/node-test-pull-request/16231/ |
Sorry, something went wrong.
common.fileExists() can be replaced with fs.existsSync(). PR-URL: nodejs#22151 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
|
Strangely, we have CI fails now due to this test: See #22104 (comment) |
Sorry, something went wrong.
That test was added to the codebase in between the last CI for this PR (2 days ago) and it landing today. |
Sorry, something went wrong.
test-trace-event-promises.js was added to the codebase between the last CI for nodejs#22151 and it landing. Refs: nodejs#22151
test-trace-event-promises.js was added to the codebase between the last CI for #22151 and it landing. PR-URL: #22200 Refs: #22151 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
|
Oops! Add this to the list of reasons to get https://github.com/nodejs/commit-queue happening. @nodejs/commit-queue |
Sorry, something went wrong.
test-trace-event-promises.js was added to the codebase between the last CI for #22151 and it landing. PR-URL: #22200 Refs: #22151 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
common.fileExists() can be replaced with fs.existsSync(). PR-URL: #22151 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
|
Missed one in /internet/: |
Sorry, something went wrong.
test-trace-event-promises.js was added to the codebase between the last CI for nodejs/node#22151 and it landing. PR-URL: nodejs/node#22200 Refs: nodejs/node#22151 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
common.fileExists() can be replaced with fs.existsSync(). PR-URL: nodejs/node#22151 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
common.fileExists() can be replaced with fs.existsSync().
fs.existsSync() was undeprecated in Node.js 6.8.0.
Checklist