FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: fix up doc comment for experimental-worker bool by addaleax · Pull Request #22165 · nodejs/node · GitHub

/ node Public

src: fix up doc comment for experimental-worker bool - #22165

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:worker-experimental-comment-fix
Closed

src: fix up doc comment for experimental-worker bool#22165
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:worker-experimental-comment-fix

Conversation

addaleax commented Aug 6, 2018

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Copy link
Copy Markdown
Collaborator

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 6, 2018
addaleax added lib / src Issues and PRs related to general changes in the lib or src directory. fast-track PRs that do not need to wait for 48 hours to land. labels Aug 7, 2018

addaleax commented Aug 7, 2018

Copy link
Copy Markdown
Member Author

Collaborators, feel free to 👍 this comment to fast track

(Not starting a full CI run here since this is only modifying comments)

vsemozhetbyt added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 7, 2018

addaleax commented Aug 9, 2018

Copy link
Copy Markdown
Member Author

Landed in 566d11a

addaleax closed this Aug 9, 2018
addaleax deleted the worker-experimental-comment-fix branch August 9, 2018 00:14
addaleax added a commit that referenced this pull request Aug 9, 2018
PR-URL: #22165
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Aug 11, 2018
PR-URL: #22165
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
PR-URL: nodejs/node#22165
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL