FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

benchmark: improve assert benchmarks by BridgeAR · Pull Request #22211 · nodejs/node · GitHub

/ node Public

benchmark: improve assert benchmarks - #22211

Closed
BridgeAR wants to merge 1 commit into
nodejs:masterfrom
BridgeAR:refactor-assert-benchmarks
ConversationCommits (1)ChecksFiles changed
Closed

benchmark: improve assert benchmarks#22211
BridgeAR wants to merge 1 commit into
nodejs:masterfrom
BridgeAR:refactor-assert-benchmarks

Conversation

BridgeAR commented Aug 9, 2018

Copy link
Copy Markdown
Member

This reduces the runtime and makes sure the strict and loose options
can be tested individually and reduces the code size.

Besides that a few redundant cases were removed.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

benchmark: improve assert benchmarks
7df0df6 
This reduces the runtime and makes sure the strict and loose options
can be tested individually.

Besides that a couple of redundant cases were removed.

nodejs-github-bot commented Aug 9, 2018

Copy link
Copy Markdown
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/474/pipeline

nodejs-github-bot added assert Issues and PRs related to the assert subsystem. benchmark Issues and PRs related to the benchmark subsystem. test Issues and PRs related to the tests. labels Aug 9, 2018
benjamingr approved these changes Aug 9, 2018
View reviewed changes

benjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for splitting - changes LGTM + nice work cutting down the LoC

mcollina commented Aug 9, 2018

Copy link
Copy Markdown
Member

Can you run the benchmarks before/after? How the output changes?

mcollina approved these changes Aug 9, 2018
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

BridgeAR commented Aug 9, 2018

Copy link
Copy Markdown
Member Author

Benchmark new: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/223/

Benchmark old: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/224/ (just a different PR without this change).

I do not run a full CI here as it does not seem to be necessary.

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 9, 2018
BridgeAR mentioned this pull request Aug 11, 2018
Closed
4 tasks

jasnell commented Aug 12, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/16386/

BridgeAR commented Aug 13, 2018

Copy link
Copy Markdown
Member Author

CI https://ci.nodejs.org/job/node-test-commit/20474/ ✔️

BridgeAR added a commit to BridgeAR/node that referenced this pull request Aug 13, 2018
benchmark: improve assert benchmarks
5442c28 
This reduces the runtime and makes sure the strict and loose options
can be tested individually.

Besides that a couple of redundant cases were removed.

PR-URL: nodejs#22211
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

BridgeAR commented Aug 13, 2018

Copy link
Copy Markdown
Member Author

Landed in 5442c28 🎉

BridgeAR closed this Aug 13, 2018
rvagg pushed a commit that referenced this pull request Aug 15, 2018
benchmark: improve assert benchmarks
00f9503 
This reduces the runtime and makes sure the strict and loose options
can be tested individually.

Besides that a couple of redundant cases were removed.

PR-URL: #22211
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg mentioned this pull request Aug 15, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
beevelop mentioned this pull request Aug 16, 2018
Closed
BridgeAR deleted the refactor-assert-benchmarks branch January 20, 2020 11:35
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
benchmark: improve assert benchmarks
1c57701 
This reduces the runtime and makes sure the strict and loose options
can be tested individually.

Besides that a couple of redundant cases were removed.

PR-URL: nodejs/node#22211
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes
benjamingr benjamingr approved these changes
trivikr trivikr approved these changes
+1 more reviewer
apapirovski apapirovski approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL