FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

inspector: tie objects lifetime to the thread they belong to by eugeneo · Pull Request #22242 · nodejs/node · GitHub

/ node Public

inspector: tie objects lifetime to the thread they belong to - #22242

Merged
eugeneo merged 0 commit into
nodejs:masterfrom
eugeneo:objects_live_in_thread
Aug 14, 2018
Merged

inspector: tie objects lifetime to the thread they belong to#22242
eugeneo merged 0 commit into
nodejs:masterfrom
eugeneo:objects_live_in_thread

Conversation

eugeneo commented Aug 10, 2018

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

This is needed for #21364

Copy link
Copy Markdown
Collaborator

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 10, 2018

trivikr commented Aug 12, 2018

Copy link
Copy Markdown
Member

trivikr added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 12, 2018

eugeneo commented Aug 13, 2018

Copy link
Copy Markdown
Contributor Author

Fixed Visual C++ compilation.

CI: https://ci.nodejs.org/job/node-test-pull-request/16424/

eugeneo commented Aug 13, 2018

Copy link
Copy Markdown
Contributor Author

Windows CI failure is #21425
LinuxOne is an infrastructure issue.

eugeneo closed this Aug 14, 2018
eugeneo deleted the objects_live_in_thread branch August 14, 2018 16:09

eugeneo commented Aug 14, 2018

Copy link
Copy Markdown
Contributor Author

eugeneo merged commit 7404a4d into nodejs:master Aug 14, 2018
rvagg pushed a commit that referenced this pull request Aug 15, 2018
PR-URL: #22242
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
PR-URL: nodejs/node#22242
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL