doc: clarify http2 docs around class exports - #22247
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
@jasnell build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/503/pipeline |
Sorry, something went wrong.
addaleax
approved these changes
Aug 10, 2018
lpinca
approved these changes
Aug 10, 2018
cjihrig
approved these changes
Aug 10, 2018
gdams
approved these changes
Aug 10, 2018
Copy link
Copy Markdown
Member
Author
|
Please 👍 to fast-track |
Sorry, something went wrong.
vsemozhetbyt
approved these changes
Aug 11, 2018
Comment thread
doc/api/http2.md
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nit: the -> The.
Sorry, something went wrong.
Comment thread
doc/api/http2.md
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Ditto.
Sorry, something went wrong.
trivikr
reviewed
Aug 12, 2018
Comment thread
doc/api/http2.md
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Typo . th# -> #
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
grr... sigh.
Sorry, something went wrong.
trivikr
approved these changes
Aug 12, 2018
jasnell
force-pushed
the
http2-clarify-docs
branch
from
616491b to
12034bd
Compare
August 12, 2018 05:25
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
gdams
approved these changes
Aug 12, 2018
gdams
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
landed in: d3d5982 |
Sorry, something went wrong.
gdams
pushed a commit
that referenced
this pull request
Aug 12, 2018
PR-URL: #22247 Fixes: #21434 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Aug 13, 2018
PR-URL: #22247 Fixes: #21434 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Aug 16, 2018
This was referenced Aug 16, 2018
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Sep 25, 2018
PR-URL: nodejs#22247 Fixes: nodejs#21434 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Oct 16, 2018
PR-URL: nodejs#22247 Fixes: nodejs#21434 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Oct 17, 2018
Backport-PR-URL: #22850 PR-URL: #22247 Fixes: #21434 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
firass111
pushed a commit
to firass111/Project_node1
that referenced
this pull request
Apr 16, 2025
PR-URL: nodejs/node#22247 Fixes: nodejs/node#21434 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #21434
Checklist