FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: extract validateNumber validator by maclover7 · Pull Request #22249 · nodejs/node · GitHub

/ node Public

lib: extract validateNumber validator - #22249

Closed
maclover7 wants to merge 1 commit into
nodejs:masterfrom
maclover7:jm-validatenumber
ConversationCommits (1)ChecksFiles changed
Closed

lib: extract validateNumber validator#22249
maclover7 wants to merge 1 commit into
nodejs:masterfrom
maclover7:jm-validatenumber

Conversation

maclover7 commented Aug 10, 2018

Copy link
Copy Markdown
Contributor

Pulls out another common argument validator to internal/validators

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

lib: extract validateNumber validator
656027e 
Pulls out another common argument validator to `internal/validators`

nodejs-github-bot commented Aug 10, 2018

Copy link
Copy Markdown
Collaborator

@maclover7 build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/505/pipeline

nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Aug 10, 2018

maclover7 commented Aug 11, 2018

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/16359/

trivikr commented Aug 12, 2018

Copy link
Copy Markdown
Member

Resumed build: https://ci.nodejs.org/job/node-test-pull-request/16378/

maclover7 commented Aug 14, 2018

Copy link
Copy Markdown
Contributor Author

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16437/

trivikr commented Aug 14, 2018

Copy link
Copy Markdown
Member

Resume build: https://ci.nodejs.org/job/node-test-pull-request/16440/

maclover7 commented Aug 14, 2018

Copy link
Copy Markdown
Contributor Author

Re node-test-commit-linux failures, alpine-latest-x64 is a known infrastructure flake and test.async-hooks/test-callback-error failing on fedora-latest-x64 is a known flaky test being tracked at #15985. Since all failures are non specific to this PR, going to go ahead and land this.

maclover7 closed this Aug 14, 2018

maclover7 commented Aug 14, 2018

Copy link
Copy Markdown
Contributor Author

Landed in 3e44b8c

maclover7 deleted the jm-validatenumber branch August 14, 2018 15:35
maclover7 added a commit that referenced this pull request Aug 14, 2018
lib: extract validateNumber validator
3e44b8c 
Pulls out another common argument validator to `internal/validators`

PR-URL: #22249
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
joyeecheung mentioned this pull request Aug 15, 2018
Closed

targos commented Aug 19, 2018

Copy link
Copy Markdown
Member

Should this be backported to v10.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

targos pushed a commit that referenced this pull request Aug 24, 2018
lib: extract validateNumber validator
29a5efa 
Pulls out another common argument validator to `internal/validators`

PR-URL: #22249
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
lib: extract validateNumber validator
1eac11f 
Pulls out another common argument validator to `internal/validators`

PR-URL: #22249
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
lib: extract validateNumber validator
f0153d0 
Pulls out another common argument validator to `internal/validators`

PR-URL: #22249
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Sep 6, 2018
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bengl bengl approved these changes
jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
richardlau richardlau approved these changes
trivikr trivikr approved these changes

Assignees

No one assigned

Labels

lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL