FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http2: Correcting the heading format by antsmartian · Pull Request #22262 · nodejs/node · GitHub

/ node Public

http2: Correcting the heading format - #22262

Closed
antsmartian wants to merge 1 commit into
nodejs:masterfrom
antsmartian:http2_doc_fix
ConversationCommits (1)ChecksFiles changed
Closed

http2: Correcting the heading format#22262
antsmartian wants to merge 1 commit into
nodejs:masterfrom
antsmartian:http2_doc_fix

Conversation

antsmartian commented Aug 11, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Was reading http2 docs and found this issue. Looks like a heading doesn't need code tags (``).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Aug 11, 2018

trivikr commented Aug 11, 2018

Copy link
Copy Markdown
Member

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/517/

trivikr added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 11, 2018

Trott commented Aug 11, 2018

Copy link
Copy Markdown
Member

@vsemozhetbyt @rubys (just to get the eyes of the people most familiar with our current markdown processing quirks and bugs)

vsemozhetbyt commented Aug 11, 2018

Copy link
Copy Markdown
Contributor

This is indeed a regression in the new toolchain, but it should be fixed eventually in the #22140 (checked and confirmed in #22140 (comment))

vsemozhetbyt commented Aug 11, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

We usually do not use backticks in API headings (when all the heading needs to be wrapped in backticks) and do use them for code entities in common headings.

gdams commented Aug 14, 2018

Copy link
Copy Markdown
Member

@antsmartian can you please resolve the conflicts?

vsemozhetbyt reviewed Aug 14, 2018
View reviewed changes
Comment thread doc/api/http2.md Outdated

vsemozhetbyt Aug 14, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is moving the heading intentional? It seems the next paragraph is out of topic now?

antsmartian Aug 14, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nope, I tried to resolve conflicts via browser and things didn't went well.

antsmartian Aug 14, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I will squash my commits and update the PR.

antsmartian commented Aug 14, 2018

Copy link
Copy Markdown
Contributor Author

@vsemozhetbyt Now it should be good to go. cc @gdams fixed the conflicts.

gdams commented Aug 14, 2018

Copy link
Copy Markdown
Member

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/563/

gdams commented Aug 14, 2018

Copy link
Copy Markdown
Member

landed in: fc84666

gdams closed this Aug 14, 2018
gdams pushed a commit that referenced this pull request Aug 14, 2018
http2: correcting the heading format
fc84666 
PR-URL: #22262
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
antsmartian deleted the http2_doc_fix branch August 15, 2018 02:30
rvagg pushed a commit that referenced this pull request Aug 15, 2018
http2: correcting the heading format
535e0e5 
PR-URL: #22262
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
rvagg mentioned this pull request Aug 15, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
addaleax mentioned this pull request Oct 20, 2018
Closed
2 tasks
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
http2: correcting the heading format
8d226c6 
PR-URL: nodejs/node#22262
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
trivikr trivikr approved these changes
+2 more reviewers
vsemozhetbyt vsemozhetbyt left review comments
gdams gdams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL