FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: remove harmony flags by BridgeAR · Pull Request #22285 · nodejs/node · GitHub

/ node Public

test: remove harmony flags - #22285

Closed
BridgeAR wants to merge 2 commits into
nodejs:masterfrom
BridgeAR:remove-harmon-yflag
ConversationCommits (2)ChecksFiles changed
Closed

test: remove harmony flags#22285
BridgeAR wants to merge 2 commits into
nodejs:masterfrom
BridgeAR:remove-harmon-yflag

Conversation

BridgeAR commented Aug 12, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

v8 supports BigInt and this can now be removed.
Update: I went ahead and removed all harmony flags where v8 supports it out of the box.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot commented Aug 12, 2018

Copy link
Copy Markdown
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/536/pipeline

nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 12, 2018
devsnek reviewed Aug 12, 2018
View reviewed changes
Comment thread test/parallel/test-util-inspect-bigint.js Outdated

devsnek Aug 12, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this entire file should be put into test-util-inspect.js

jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 12, 2018

jasnell commented Aug 12, 2018

Copy link
Copy Markdown
Member

Trivial enough to fast-track, I think... with or without moving into test-util-inspect.js

Please 👍 to approve fast-track.

trivikr commented Aug 12, 2018

Copy link
Copy Markdown
Member

The flag --harmony-bigint needs to be removed from documentation also

test: remove harmony flags
0450484 
v8 6.8 supports all removed flags. For example for BigInt.
devsnek reviewed Aug 13, 2018
View reviewed changes
Comment thread test/parallel/test-vm-module-import-meta.js Outdated

devsnek Aug 13, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

unrelated changes?

Comment thread test/parallel/test-vm-module-dynamic-import.js Outdated

devsnek Aug 13, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

unrelated changes?

BridgeAR force-pushed the remove-harmon-yflag branch from 3672def to 0450484 Compare August 13, 2018 00:21
BridgeAR removed the fast-track PRs that do not need to wait for 48 hours to land. label Aug 13, 2018
BridgeAR changed the title test: remove bigint harmony flag test: remove harmony flags Aug 13, 2018

BridgeAR commented Aug 13, 2018

Copy link
Copy Markdown
Member Author

I went ahead and removed all harmony flags that v8 supports out of the box and updated the commit message accordingly.

BridgeAR commented Aug 13, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

CI https://ci.nodejs.org/job/node-test-pull-request/16405/
CI https://ci.nodejs.org/job/node-test-pull-request/16406/

trivikr added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 13, 2018

trivikr commented Aug 14, 2018 •
edited by BridgeAR
Loading

Copy link
Copy Markdown
Member

Resume build: https://ci.nodejs.org/job/node-test-pull-request/16441/ ✔️

BridgeAR added a commit to BridgeAR/node that referenced this pull request Aug 15, 2018
test: remove harmony flags
525544b 
v8 6.8 supports all removed flags. For example for BigInt.

PR-URL: nodejs#22285
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

BridgeAR commented Aug 15, 2018

Copy link
Copy Markdown
Member Author

Landed in 525544b 🎉

BridgeAR closed this Aug 15, 2018
targos added backport-requested-v10.x and removed author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Aug 19, 2018

targos commented Aug 19, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Should this be backported to v10.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

Edit: the conflict was related to a semver-major change and trivial to fix.

targos pushed a commit that referenced this pull request Aug 19, 2018
test: remove harmony flags
a1c580f 
v8 6.8 supports all removed flags. For example for BigInt.

PR-URL: #22285
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
test: remove harmony flags
acfb724 
v8 6.8 supports all removed flags. For example for BigInt.

PR-URL: #22285
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Sep 5, 2018
Merged
This was referenced Sep 6, 2018
Closed
Closed
BridgeAR deleted the remove-harmon-yflag branch January 20, 2020 11:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
lpinca lpinca approved these changes
trivikr trivikr approved these changes
+1 more reviewer
devsnek devsnek left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL