FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

util: mark special entries as such by BridgeAR · Pull Request #22287 · nodejs/node · GitHub

/ node Public

util: mark special entries as such - #22287

Closed
BridgeAR wants to merge 1 commit into
nodejs:masterfrom
BridgeAR:mark-inspect-special
ConversationCommits (1)ChecksFiles changed
Closed

util: mark special entries as such#22287
BridgeAR wants to merge 1 commit into
nodejs:masterfrom
BridgeAR:mark-inspect-special

Conversation

BridgeAR commented Aug 12, 2018

Copy link
Copy Markdown
Member

This adds the color code to special entries if colors are active.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot commented Aug 12, 2018

Copy link
Copy Markdown
Collaborator

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/538/pipeline

nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Aug 12, 2018
BridgeAR force-pushed the mark-inspect-special branch 2 times, most recently from f766ef3 to b361417 Compare August 13, 2018 00:07

BridgeAR commented Aug 13, 2018

Copy link
Copy Markdown
Member Author

CI https://ci.nodejs.org/job/node-test-pull-request/16403/

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 13, 2018
lpinca reviewed Aug 13, 2018
View reviewed changes
Comment thread test/parallel/test-util-inspect.js Outdated

lpinca Aug 13, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is this assertion repeated on purpose?

trivikr Aug 14, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

removing author ready label because of this open question

BridgeAR Aug 14, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks! Copy paste error :) It's now resolved.

trivikr removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 14, 2018
BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 14, 2018

BridgeAR commented Aug 15, 2018

Copy link
Copy Markdown
Member Author

CI https://ci.nodejs.org/job/node-test-pull-request/16464/

BridgeAR force-pushed the mark-inspect-special branch from b62ab33 to 99b50c7 Compare August 15, 2018 16:09

BridgeAR commented Aug 15, 2018

Copy link
Copy Markdown
Member Author

Rebased due to conflicts.

CI https://ci.nodejs.org/job/node-test-pull-request/16466/

This was referenced Aug 17, 2018
Closed
Closed
util: mark special entries as such
2988330 
This adds the color code to special entries if colors are active.
BridgeAR force-pushed the mark-inspect-special branch from 99b50c7 to 2988330 Compare August 19, 2018 13:24

BridgeAR commented Aug 19, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

Rebased again due to conflicts.

CI https://ci.nodejs.org/job/node-test-pull-request/16569/ ✔️

BridgeAR added a commit to BridgeAR/node that referenced this pull request Aug 19, 2018
util: mark special entries as such
bd090f9 
This adds the color code to special entries if colors are active.

PR-URL: nodejs#22287
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

BridgeAR commented Aug 19, 2018

Copy link
Copy Markdown
Member Author

Landed in bd090f9 🎉

BridgeAR closed this Aug 19, 2018
targos added backport-requested-v10.x and removed author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Aug 19, 2018

targos commented Aug 19, 2018

Copy link
Copy Markdown
Member

Should this be backported to v10.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

targos commented Aug 19, 2018

Copy link
Copy Markdown
Member

Landed easily after #21869

targos pushed a commit that referenced this pull request Aug 19, 2018
util: mark special entries as such
f5341f0 
This adds the color code to special entries if colors are active.

PR-URL: #22287
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
util: mark special entries as such
1828017 
This adds the color code to special entries if colors are active.

PR-URL: #22287
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Sep 5, 2018
Merged
This was referenced Sep 6, 2018
Closed
Closed
BridgeAR deleted the mark-inspect-special branch January 20, 2020 11:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
trivikr trivikr approved these changes
+1 more reviewer
devsnek devsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL