util: properly indent special properties - #22291
Closed
BridgeAR wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Calling `formatValue()` directly requires the indentation level to be set manually. This was not the case so far in most cases and the indentation was off in all these cases.
Copy link
Copy Markdown
Collaborator
|
@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/542/pipeline |
Sorry, something went wrong.
devsnek
approved these changes
Aug 12, 2018
devsnek
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
something for another pr might be changing indentationLvl to work in single steps
Sorry, something went wrong.
addaleax
approved these changes
Aug 12, 2018
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
jasnell
approved these changes
Aug 13, 2018
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Aug 15, 2018
Calling `formatValue()` directly requires the indentation level to be set manually. This was not the case so far in most cases and the indentation was off in all these cases. PR-URL: nodejs#22291 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Member
|
Depends on #21869 to land on v10.x-staging |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Aug 19, 2018
Calling `formatValue()` directly requires the indentation level to be set manually. This was not the case so far in most cases and the indentation was off in all these cases. PR-URL: #22291 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
Calling `formatValue()` directly requires the indentation level to be set manually. This was not the case so far in most cases and the indentation was off in all these cases. PR-URL: #22291 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling formatValue() directly requires the indentation level to
be set manually. This was not the case so far in most cases and the
indentation was off in all these cases.
I tried to fix this by moving the indentation correction directly into formatValue()
but that is tricky due to a lot of special handling and early returns. Therefore it
seemed easier to just change the indentation everywhere where it's necessary.
Checklist